New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all factory use cases from intro.js #2181

Closed
mgol opened this Issue Mar 30, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Mar 30, 2015

We have a lot of logic in intro.js and we only test two: the browser use case and the most common Node+jsdom. We should cover all scenarios so that freely changing this code actually breaks some tests.

@mgol mgol added the Core label Mar 30, 2015

@mgol mgol added this to the 3.0.0 milestone Mar 30, 2015

@mgol mgol self-assigned this Mar 30, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 30, 2015

Member

We should do it before trying to fix #2177 so that it's easier to add a new test.

Member

mgol commented Mar 30, 2015

We should do it before trying to fix #2177 so that it's easier to add a new test.

mgol added a commit to mgol/jquery that referenced this issue Apr 26, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test three cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.

Fix gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 26, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test three cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.

Previously the second case was not tested and the third was tested in a way
that interfered with the main test environment.

Fix gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 26, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test three cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.

Previously the second case was not tested and the third was tested in a way
that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fix gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 26, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test three cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.

Previously the second case was not tested and the third was tested in a way
that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second case was not tested and the third was tested in a way
that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

mgol added a commit to mgol/jquery that referenced this issue Apr 27, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181

@mgol mgol closed this in ab40725 Apr 27, 2015

mgol added a commit that referenced this issue Nov 10, 2015

Core: Test all factory use cases from intro.js
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.

Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.

We now also test if in the Browserify case we're not creating a jQuery global
by default.

Fixes gh-2181
Closes gh-2234

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.