New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document in the master README excluding Sizzle is not supported in the compat/1.x build #2184

Closed
ZuBB opened this Issue Mar 30, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@ZuBB

ZuBB commented Mar 30, 2015

Original issue title: Custom build in 1.11 branch produces file which gives 'Sizzle is undefined' JS error

Hi there!

I need smallest build to debug some issue in IE8. Next command is used for cooking that build

vv@vv-Latitude-E5520 ~/work/own/uos/lss/src/html_report/javascript/jquery $ grunt custom:-ajax,-deprecated,-dimensions,-effects,-event/alias,-offset,-deferred,-wrap,-exports/amd,-core/ready,-event,-css,-sizzle

after that

vv@vv-Latitude-E5520 ~/work/own/uos/lss/src/html_report/javascript/jquery $ ack -i sizzle dist/jquery.js 
 * jQuery JavaScript Library v1.11.3-pre -ajax,-ajax/jsonp,-ajax/load,-ajax/parseJSON,-ajax/parseXML,-ajax/script,-ajax/var/nonce,-ajax/var/rquery,-ajax/xhr,-manipulation/_evalUrl,-event/ajax,-deprecated,-dimensions,-effects,-effects/Tween,-effects/animatedSelector,-effects/support,-event/alias,-offset,-deferred,-wrap,-exports/amd,-core/ready,-event,-event/support,-css,-css/addGetHookIf,-css/curCSS,-css/defaultDisplay,-css/hiddenVisibleSelectors,-css/support,-css/swap,-css/var/cssExpand,-css/var/isHidden,-css/var/rmargin,-css/var/rnumnonpx,-sizzle
 * Includes Sizzle.js
 * http://sizzlejs.com/
    version = "1.11.3-pre -ajax,-ajax/jsonp,-ajax/load,-ajax/parseJSON,-ajax/parseXML,-ajax/script,-ajax/var/nonce,-ajax/var/rquery,-ajax/xhr,-manipulation/_evalUrl,-event/ajax,-deprecated,-dimensions,-effects,-effects/Tween,-effects/animatedSelector,-effects/support,-event/alias,-offset,-deferred,-wrap,-exports/amd,-core/ready,-event,-event/support,-css,-css/addGetHookIf,-css/curCSS,-css/defaultDisplay,-css/hiddenVisibleSelectors,-css/support,-css/swap,-css/var/cssExpand,-css/var/isHidden,-css/var/rmargin,-css/var/rnumnonpx,-sizzle",
jQuery.find = Sizzle;
jQuery.expr = Sizzle.selectors;
jQuery.unique = Sizzle.uniqueSort;
jQuery.text = Sizzle.getText;
jQuery.isXMLDoc = Sizzle.isXML;
jQuery.contains = Sizzle.contains;
                    // Don't pass non-elements to Sizzle
            // We eschew Sizzle here for performance reasons: http://jsperf.com/getall-vs-sizzle/2
vv@vv-Latitude-E5520 ~/work/own/uos/lss/src/html_report/javascript/jquery $ 

and here is error
screenshot_2015 03 30_19-05-11utc

just for the record: 2.1.3 is not affected

vv@vv-Latitude-E5520 ~/work/own/uos/lss/src/html_report/javascript/jquery $ ack -i sizzle dist/jquery.js 
 * Includes Sizzle.js
 * http://sizzlejs.com/
 * Optional (non-Sizzle) selector module for custom builds.
 * custom selectors via Sizzle extensions
 * If any of these are unacceptable tradeoffs, either use Sizzle or
        // Same basic safeguard as Sizzle
                    // Don't pass non-elements to Sizzle
            // We eschew Sizzle here for performance reasons: http://jsperf.com/getall-vs-sizzle/2
vv@vv-Latitude-E5520 ~/work/own/uos/lss/src/html_report/javascript/jquery $ 
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 30, 2015

Member

Excluding Sizzle is not supported in jQuery 1. It's said in the README for the compat branch but perhaps everyone just reads the main README so we should add such a note there as well.

Member

mgol commented Mar 30, 2015

Excluding Sizzle is not supported in jQuery 1. It's said in the README for the compat branch but perhaps everyone just reads the main README so we should add such a note there as well.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 30, 2015

Member

Let's morph it into the docs issue.

Member

mgol commented Mar 30, 2015

Let's morph it into the docs issue.

@mgol mgol changed the title from Custom build in 1.11 branch produces file which gives 'Sizzle is undefined' JS error to Document in the master README excluding Sizzle is not supported in the compat/1.x build (was: Custom build in 1.11 branch produces file which gives 'Sizzle is undefined' JS error) Mar 30, 2015

@mgol mgol modified the milestones: 1.11.3/2.1.4, 3.0.0 Mar 30, 2015

@mgol mgol changed the title from Document in the master README excluding Sizzle is not supported in the compat/1.x build (was: Custom build in 1.11 branch produces file which gives 'Sizzle is undefined' JS error) to Document in the master README excluding Sizzle is not supported in the compat/1.x build Mar 30, 2015

@ZuBB

This comment has been minimized.

Show comment
Hide comment
@ZuBB

ZuBB Mar 30, 2015

Thanks for a quick help

ZuBB commented Mar 30, 2015

Thanks for a quick help

@mgol mgol closed this in 062b526 Mar 30, 2015

mgol added a commit that referenced this issue Nov 10, 2015

Docs: Add info about Sizzle not being excludable on the compat branch
Most people just read the README that's displayed to them on GitHub which
is the one for the master branch. Let's include the info about Sizzle
not being excludable there.

Fixes gh-2184

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.