New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery.unique #2228

Closed
gibson042 opened this Issue Apr 22, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@gibson042
Member

gibson042 commented Apr 22, 2015

jQuery.unique is an alias to the better-named Sizzle.uniqueSort, and the fact that it sorts has surprised even our own team members.

We should deprecate jQuery.unique in favor of jQuery.uniqueSort (which will need to be introduced).

@gibson042 gibson042 added the Core label Apr 22, 2015

@gibson042 gibson042 added this to the 3.0.0 milestone Apr 22, 2015

@dcherman

This comment has been minimized.

Show comment
Hide comment
@dcherman

dcherman Apr 22, 2015

Contributor

👍

Personally, all of my usage of $.unique has been for the side effect that it sorts the collection. I usually end up doing var sortByDomOrder = $.unique to make that clear to people that aren't familiar with that side effect, so this name change will be nice.

Contributor

dcherman commented Apr 22, 2015

👍

Personally, all of my usage of $.unique has been for the side effect that it sorts the collection. I usually end up doing var sortByDomOrder = $.unique to make that clear to people that aren't familiar with that side effect, so this name change will be nice.

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Apr 22, 2015

Member

SGTM too 👍

Member

dmethvin commented Apr 22, 2015

SGTM too 👍

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Apr 23, 2015

Member

Woot! 👍

Member

timmywil commented Apr 23, 2015

Woot! 👍

@timmywil timmywil self-assigned this May 4, 2015

@timmywil timmywil closed this in e1090c3 May 4, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.