New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated `bind`, `unbind`, `delegate`, `undelegate` methods #2288

Closed
markelog opened this Issue May 9, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@markelog
Member

markelog commented May 9, 2015

I guess it is time to do this.

  1. Move them to deprecated module
  2. Add warnings into jquery-migrate
  3. Update the docs

@markelog markelog added the Event label May 9, 2015

@markelog markelog added this to the 3.0.0 milestone May 9, 2015

@markelog markelog added the Docs label May 9, 2015

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 9, 2015

Member

Yes please! 👍

Member

arthurvr commented May 9, 2015

Yes please! 👍

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin May 10, 2015

Member

I'm okay with all these todos, although I don't think we'd actually remove them quickly given how much code is still around that uses it. They are very small stubs anyway.

Member

dmethvin commented May 10, 2015

I'm okay with all these todos, although I don't think we'd actually remove them quickly given how much code is still around that uses it. They are very small stubs anyway.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol May 10, 2015

Member

@dmethvin Agreed. I don't think it's worth removing them any time soon because of their extremely small size & widespread adoption but discouraging use seems OK.

That said, with current setup only Migrate users & people looking at the docs will see the warnings; maybe we should do it in Core as well?

Member

mgol commented May 10, 2015

@dmethvin Agreed. I don't think it's worth removing them any time soon because of their extremely small size & widespread adoption but discouraging use seems OK.

That said, with current setup only Migrate users & people looking at the docs will see the warnings; maybe we should do it in Core as well?

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin May 10, 2015

Member

As long as we don't actually remove them any time soon, the warning in Migrate should be fine.

Member

dmethvin commented May 10, 2015

As long as we don't actually remove them any time soon, the warning in Migrate should be fine.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog May 10, 2015

Member

Yeah, definitely, no hurry.

Member

markelog commented May 10, 2015

Yeah, definitely, no hurry.

@sabberworm

This comment has been minimized.

Show comment
Hide comment
@sabberworm

sabberworm Jul 6, 2016

The docs still don’t mention the deprecation even though this issue is closed and it specifically says “3. Update the docs”…

See jquery/api.jquery.com#945.

sabberworm commented Jul 6, 2016

The docs still don’t mention the deprecation even though this issue is closed and it specifically says “3. Update the docs”…

See jquery/api.jquery.com#945.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jul 7, 2016

Member

Yeah, you right, although i don't think we should re-open this ticket, let's just discuss this in jquery/api.jquery.com#945? Btw would you like to send us a PR for it? If @teo1978 does not beat you to it?

Member

markelog commented Jul 7, 2016

Yeah, you right, although i don't think we should re-open this ticket, let's just discuss this in jquery/api.jquery.com#945? Btw would you like to send us a PR for it? If @teo1978 does not beat you to it?

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.