Events: originalEvent must not be an empty object #2300

Closed
gabrielschulhof opened this Issue May 12, 2015 · 4 comments

Comments

Projects
None yet
5 participants
@gabrielschulhof
Contributor

gabrielschulhof commented May 12, 2015

Since a873558 we must make sure that all objects that are supposed to be events are events. Thus, code like originalEvent: {} must be replaced with originalEvent: new jQuery.Event()

@mgol mgol added this to the 3.0.0 milestone May 12, 2015

@mgol mgol added the Event label May 12, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery that referenced this issue May 12, 2015

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil May 12, 2015

Member

I took the liberty of assigning you, @markelog. :)

Member

timmywil commented May 12, 2015

I took the liberty of assigning you, @markelog. :)

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog May 12, 2015

Member

@timmywil Sure thing,

Since a873558 we must make sure that all objects that are supposed to be events are events.

Why?

Member

markelog commented May 12, 2015

@timmywil Sure thing,

Since a873558 we must make sure that all objects that are supposed to be events are events.

Why?

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil May 12, 2015

Member

Because our simulated focus event doesn't have those methods.

Member

timmywil commented May 12, 2015

Because our simulated focus event doesn't have those methods.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 12, 2015

Contributor

@gibson042 mentioned that we may be able to get rid of the fake originalEvent altogether.

Contributor

gabrielschulhof commented May 12, 2015

@gibson042 mentioned that we may be able to get rid of the fake originalEvent altogether.

gabrielschulhof added a commit to gabrielschulhof/jquery that referenced this issue May 12, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery that referenced this issue May 12, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery that referenced this issue May 13, 2015

markelog added a commit to markelog/jquery that referenced this issue May 20, 2015

markelog added a commit to markelog/jquery that referenced this issue May 20, 2015

markelog added a commit to markelog/jquery that referenced this issue May 20, 2015

markelog added a commit to markelog/jquery that referenced this issue May 28, 2015

@markelog markelog closed this in 7475d5d May 29, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@mgol mgol removed the Has Pull Request label Mar 6, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.