New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal args to .on & .remove #2301

Closed
mgol opened this Issue May 12, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented May 12, 2015

We shouldn't be exposing our private APIs, even if it's just via undocumented additional params.

I found 2 such occurrences: .on & .remove.

@mgol mgol self-assigned this May 12, 2015

@mgol mgol added this to the 3.0.0 milestone May 12, 2015

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin May 13, 2015

Member

I agree. We got rid of several of these earlier, not sure why these stayed around.

Member

dmethvin commented May 13, 2015

I agree. We got rid of several of these earlier, not sure why these stayed around.

mgol added a commit to mgol/jquery that referenced this issue Jun 1, 2015

mgol added a commit to mgol/jquery that referenced this issue Jun 1, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 1, 2015

Member

PR: #2366

Member

mgol commented Jun 1, 2015

PR: #2366

mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015

mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015

mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015

mgol added a commit to mgol/jquery that referenced this issue Jun 13, 2015

@mgol mgol closed this in #2366 Jun 13, 2015

mgol added a commit that referenced this issue Jun 13, 2015

mgol added a commit that referenced this issue Jun 13, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.