Deal with UA string of the Microsoft Edge #2357

Closed
markelog opened this Issue May 28, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@markelog
Member

markelog commented May 28, 2015

As noted by the @dmethvin.

See https://msdn.microsoft.com/en-us/library/hh869301%28v=vs.85%29.aspx

Since our tests (mostly support tests) depends on that.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 14, 2015

Member

Hmm, it seems I partially took care of it via 8e111df.

See also #2390 for a summary of where we're staying with MS Edge.

Member

mgol commented Jun 14, 2015

Hmm, it seems I partially took care of it via 8e111df.

See also #2390 for a summary of where we're staying with MS Edge.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 22, 2015

Member

I've search the code from master and, apart from test/unit/support.js the event originalEvent test is the only place where we sniff for Chrome. In other places we only sniff for:

  1. Android
  2. iOS
  3. Firefox (in one place, to disable focus tests).

No Chrome & IE. Therefore, the originalEvent test is the only place that's left to change (as you said, only the test description & message should be changed to include Edge).

That seems to be it.

Member

mgol commented Jun 22, 2015

I've search the code from master and, apart from test/unit/support.js the event originalEvent test is the only place where we sniff for Chrome. In other places we only sniff for:

  1. Android
  2. iOS
  3. Firefox (in one place, to disable focus tests).

No Chrome & IE. Therefore, the originalEvent test is the only place that's left to change (as you said, only the test description & message should be changed to include Edge).

That seems to be it.

@mgol mgol added the Build label Sep 8, 2015

@mgol mgol self-assigned this Sep 8, 2015

@mgol mgol added this to the 3.0.0 milestone Sep 8, 2015

@mgol mgol closed this in 64fd7ef Sep 14, 2015

mgol added a commit that referenced this issue Sep 14, 2015

Tests: Account for Edge in originalEvent UA-sniffs
All other cases where Edge user agent needed to be taken into account
in tests have already been resolved.

(cherry-picked from 64fd7ef)

Fixes gh-2357

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.