New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge fails the focusin support test #2389

Closed
mgol opened this Issue Jun 14, 2015 · 15 comments

Comments

Projects
None yet
6 participants
@mgol
Member

mgol commented Jun 14, 2015

In Microsoft Edge (from the newest Windows 10 build 10130) there is no window.onfocusin which makes our focusin support test to fail and use our polyfill for the focusin/focusout event in Edge.

It would be good to contact the MS team about this problem before Windows 10 arrives. (@dmethvin?)

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jun 15, 2015

Member

Oh god, no, that is bad, i don't any good way to feature test it. Does it behave according to the specification? Or it follows Chrome style now?

As i said in the #2360 (comment) we need a reliable way to test it.

@jacobrossi could please help us out here?

Member

markelog commented Jun 15, 2015

Oh god, no, that is bad, i don't any good way to feature test it. Does it behave according to the specification? Or it follows Chrome style now?

As i said in the #2360 (comment) we need a reliable way to test it.

@jacobrossi could please help us out here?

@jacobrossi

This comment has been minimized.

Show comment
Hide comment
@jacobrossi

jacobrossi Jun 15, 2015

Let me look at the change we made specifically and I'll reply back with some details

Let me look at the change we made specifically and I'll reply back with some details

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 15, 2015

Member

@jacobrossi Thanks!

Member

mgol commented Jun 15, 2015

@jacobrossi Thanks!

@jacobrossi

This comment has been minimized.

Show comment
Hide comment
@jacobrossi

jacobrossi Jun 15, 2015

Update: we already have an internal bug tracking this since we run the jQuery test suite in our automation. I reached out to the bug owner for details if this is something deliberate we changed or just a bug. I suspect we changed to match Chrome behavior.

Update: we already have an internal bug tracking this since we run the jQuery test suite in our automation. I reached out to the bug owner for details if this is something deliberate we changed or just a bug. I suspect we changed to match Chrome behavior.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 15, 2015

Member

@jacobrossi thanks, looking forward to it. We'd love help with #2390 as well; we have a workaround for IE that sniffs for documentMode that now breaks.

Member

mgol commented Jun 15, 2015

@jacobrossi thanks, looking forward to it. We'd love help with #2390 as well; we have a workaround for IE that sniffs for documentMode that now breaks.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jun 15, 2015

Member

@jacobrossi thank you for the replay.

I suspect we changed to match Chrome behavior.

Please don't follow chrome behaviour if it contradicts the specification, which it does in this case :(

Member

markelog commented Jun 15, 2015

@jacobrossi thank you for the replay.

I suspect we changed to match Chrome behavior.

Please don't follow chrome behaviour if it contradicts the specification, which it does in this case :(

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jun 15, 2015

Member

We might switch to email conversation, but just in case -
/cc @reybango

Member

markelog commented Jun 15, 2015

We might switch to email conversation, but just in case -
/cc @reybango

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 16, 2015

Member

Do we still need this ticket? There's nothing else to do on our side so e.g. having a milestone seems wrong here.

Member

mgol commented Oct 16, 2015

Do we still need this ticket? There's nothing else to do on our side so e.g. having a milestone seems wrong here.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Oct 16, 2015

Member

Well, onfocus(in | out) still works correctly in Edge but now we can't check it, we might come up with different way to solve it or leave it as a remainder for us to bug Edge ppl :-).

Maybe @jdalton could shade some light on it? Like if this issue has different solution that we overlooked or if whenever or not it will be solved soon on the Edge end?

Member

markelog commented Oct 16, 2015

Well, onfocus(in | out) still works correctly in Edge but now we can't check it, we might come up with different way to solve it or leave it as a remainder for us to bug Edge ppl :-).

Maybe @jdalton could shade some light on it? Like if this issue has different solution that we overlooked or if whenever or not it will be solved soon on the Edge end?

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 16, 2015

Member

Yes, but keeping it on the 3.0.0 milestone creates an impression we have more work to do for 3.0.0 than we really do and wer're trying to lower the number down currently.

So I'd like to at least remove the milestone.

Member

mgol commented Oct 16, 2015

Yes, but keeping it on the 3.0.0 milestone creates an impression we have more work to do for 3.0.0 than we really do and wer're trying to lower the number down currently.

So I'd like to at least remove the milestone.

@markelog markelog removed this from the 3.0.0 milestone Oct 16, 2015

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Oct 16, 2015

Member

Done :-)

Member

markelog commented Oct 16, 2015

Done :-)

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Oct 17, 2015

Member

I've looked into this and haven't come up with a tiny snippet that doesn't require inserting into the dom.
I'll keep kicking it around.

Member

jdalton commented Oct 17, 2015

I've looked into this and haven't come up with a tiny snippet that doesn't require inserting into the dom.
I'll keep kicking it around.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jan 14, 2016

Member

I trust @jdalton has been thoroughly bugged about this. I've added a note to the Roadmap for keeping in touch with Edge about focusin/out, but am closing this issue.

Member

timmywil commented Jan 14, 2016

I trust @jdalton has been thoroughly bugged about this. I've added a note to the Roadmap for keeping in touch with Edge about focusin/out, but am closing this issue.

@timmywil timmywil closed this Jan 14, 2016

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Jan 14, 2016

Member

Cool, cool.

Member

jdalton commented Jan 14, 2016

Cool, cool.

@phistuck

This comment has been minimized.

Show comment
Hide comment
@phistuck

phistuck Oct 10, 2016

@markelog -

Please don't follow chrome behaviour if it contradicts the specification, which it does in this case :(

I do not see anything relevant filed on https://crbug.com - if no one hollers, there is a smaller chance of them adding it...

phistuck commented Oct 10, 2016

@markelog -

Please don't follow chrome behaviour if it contradicts the specification, which it does in this case :(

I do not see anything relevant filed on https://crbug.com - if no one hollers, there is a smaller chance of them adding it...

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.