Microsoft Edge fails the "Iframe dispatch should not affect jQuery (#13936)" test #2390

Closed
mgol opened this Issue Jun 14, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@mgol
Member

mgol commented Jun 14, 2015

Microsoft Edge (from the newest Windows 10 build 10130) fails the "Iframe dispatch should not affect jQuery (#13936)" test with an error:

{
  "description": "Permission denied",
  "message": "Permission denied",
  "name": "TypeError",
  "number": -2146828218
}

All others pass if you test modules individually. There are a couple of support tests that now pass (compared to IE11): boxSizingReliable (this one didn't pass in the previous build from April 29), noCloneChecked, optSelected, radioValue. The focusin test now fails, see #2389.

Interestingly enough, if you run the whole test suite it fails a lot more tests; most likely this one leaves the browser in a bad state.

Screenshot:
screen shot 2015-06-14 at 02 02 37

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 14, 2015

Member

Note: I added MS Edge support test results in 8e111df & 546593b so that the browser is not erroneously detected as Chrome.

Member

mgol commented Jun 14, 2015

Note: I added MS Edge support test results in 8e111df & 546593b so that the browser is not erroneously detected as Chrome.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 15, 2015

Member

Sizzle issue: jquery/sizzle#339

Member

mgol commented Jun 15, 2015

Sizzle issue: jquery/sizzle#339

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Jun 15, 2015

Member

@jacobrossi Specifically, this would not be an issue if IE Edge didn't throw "permission denied" when accessing the document of an unloaded iframe; see jquery/sizzle@a431c02 and http://bugs.jquery.com/ticket/13936 .

Member

gibson042 commented Jun 15, 2015

@jacobrossi Specifically, this would not be an issue if IE Edge didn't throw "permission denied" when accessing the document of an unloaded iframe; see jquery/sizzle@a431c02 and http://bugs.jquery.com/ticket/13936 .

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 15, 2015

Member

Specifically, this would not be an issue if IE Edge didn't throw "permission denied" when accessing the document of an unloaded iframe

Yup, especially that we cannot change the code of many older jQuery versions that live in the wild.

Member

mgol commented Jun 15, 2015

Specifically, this would not be an issue if IE Edge didn't throw "permission denied" when accessing the document of an unloaded iframe

Yup, especially that we cannot change the code of many older jQuery versions that live in the wild.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 19, 2015

Member

For people following, there has been a discussion about that at jquery/sizzle@28f4c67.

Member

mgol commented Jun 19, 2015

For people following, there has been a discussion about that at jquery/sizzle@28f4c67.

@mgol mgol removed the Needs review label Jun 22, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 25, 2015

Member

I'd mark it as a blocker; it's very simple to revert the additional check and it'd be good to have it in for an alpha.

That'd require a Sizzle update, though, so I'll leave it up to you.

Member

mgol commented Jun 25, 2015

I'd mark it as a blocker; it's very simple to revert the additional check and it'd be good to have it in for an alpha.

That'd require a Sizzle update, though, so I'll leave it up to you.

@jacobrossi

This comment has been minimized.

Show comment
Hide comment
@jacobrossi

jacobrossi Jun 25, 2015

We're tracking fixing this. Unfortunately there's a fairly gnarly issue related to iframe security features we have that make this quite the issue to fix. We're working on stabilizing Edge for the first release, which means a massive change like this isn't appropriate at this time. But we're going to look at fixing this nonetheless after we get the first version out the door.

We're tracking fixing this. Unfortunately there's a fairly gnarly issue related to iframe security features we have that make this quite the issue to fix. We're working on stabilizing Edge for the first release, which means a massive change like this isn't appropriate at this time. But we're going to look at fixing this nonetheless after we get the first version out the door.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Aug 17, 2015

Member

It's now fixed in Sizzle so I added the "Awaiting Sizzle update" label.

Member

mgol commented Aug 17, 2015

It's now fixed in Sizzle so I added the "Awaiting Sizzle update" label.

@mgol mgol added the Blocker label Aug 17, 2015

@markelog markelog closed this in 44f8239 Oct 17, 2015

markelog added a commit that referenced this issue Oct 25, 2015

Build: update Sizzle to 2.2.1
Ref #2644 - `selector` module in Edge - Waiting for Sizzle update
Fixes #2390

(cherry picked from commit 44f8239)

Conflicts:
	package.json

gibson042 added a commit that referenced this issue Oct 25, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.