New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test/data/ua.txt #2398

Closed
mgol opened this Issue Jun 16, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Jun 16, 2015

The test/data/ua.txt seems to be a leftover from when $.browser existed to have data to compare to? Nothing refers to it, it seems we can remove it.

@mgol mgol added the Build label Jun 16, 2015

@mgol mgol self-assigned this Jun 16, 2015

@mgol mgol added this to the 3.0.0 milestone Jun 16, 2015

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Jun 16, 2015

Member

Yes, as you guessed those were used to see if the $.browser results seemed sane. They should go.

Member

dmethvin commented Jun 16, 2015

Yes, as you guessed those were used to see if the $.browser results seemed sane. They should go.

@mgol mgol closed this in e831856 Jun 16, 2015

mgol added a commit that referenced this issue Jun 16, 2015

Tests: Remove test/data/ua.txt
The file was used by $.browser tests but $.browser now doesn't exists
in Core and this file hasn't been updated for a few years.

(cherry-picked from e831856)

Fixes gh-2398

mgol added a commit that referenced this issue Nov 10, 2015

Tests: Remove test/data/ua.txt
The file was used by $.browser tests but $.browser now doesn't exists
in Core and this file hasn't been updated for a few years.

Fixes gh-2398

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.