The build process requires no space between closing `}` and `)` #2399

Closed
mgol opened this Issue Jun 16, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@mgol
Member

mgol commented Jun 16, 2015

Our build process requires no space between closing } and ) for variable modules (i.e. those with paths containing /var/). This makes it impossible to follow our style guide and write those modules in this way:

define( function() {
    /* code */
} );

instead of currently required:

define( function() {
    /* code */
} );

There may be other cases like that in used regexes.

I'll assign this to @timmywil since it's his code. I hope you don't mind, Timmy. :-)

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jun 16, 2015

Member

Yea, I'll make it optional.

Member

timmywil commented Jun 16, 2015

Yea, I'll make it optional.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 18, 2015

Member

Why wasn't this auto-closed?

Member

mgol commented Jun 18, 2015

Why wasn't this auto-closed?

@timmywil timmywil closed this in 63a577a Jun 19, 2015

markelog added a commit to markelog/jquery that referenced this issue Sep 3, 2015

markelog added a commit to markelog/jquery that referenced this issue Sep 3, 2015

markelog added a commit to markelog/jquery that referenced this issue Sep 3, 2015

@dmethvin dmethvin removed this from the 3.0.0 milestone Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.