Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build process requires no space between closing } and ) #2399

Closed
mgol opened this issue Jun 16, 2015 · 2 comments
Closed

The build process requires no space between closing } and ) #2399

mgol opened this issue Jun 16, 2015 · 2 comments
Assignees
Labels

Comments

@mgol
Copy link
Member

mgol commented Jun 16, 2015

Our build process requires no space between closing } and ) for variable modules (i.e. those with paths containing /var/). This makes it impossible to follow our style guide and write those modules in this way:

define( function() {
    /* code */
} );

instead of currently required:

define( function() {
    /* code */
} );

There may be other cases like that in used regexes.

I'll assign this to @timmywil since it's his code. I hope you don't mind, Timmy. :-)

@timmywil
Copy link
Member

Yea, I'll make it optional.

@mgol
Copy link
Member Author

mgol commented Jun 18, 2015

Why wasn't this auto-closed?

markelog pushed a commit to markelog/jquery that referenced this issue Sep 3, 2015
markelog pushed a commit to markelog/jquery that referenced this issue Sep 3, 2015
markelog pushed a commit to markelog/jquery that referenced this issue Sep 3, 2015
timmywil added a commit that referenced this issue Sep 7, 2015
@dmethvin dmethvin removed this from the 3.0.0 milestone Jan 7, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants