New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse support.ownLast #2406

Closed
mgol opened this Issue Jun 17, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Jun 17, 2015

jQuery.support.ownLast is the only support test that's supposed to be false when it succeeds. It's confusing, we should reverse its value.

@mgol mgol added the 1.x-only label Jun 17, 2015

@mgol mgol added this to the 3.0.0 milestone Jun 17, 2015

@mgol mgol self-assigned this Jun 17, 2015

mgol added a commit to mgol/jquery that referenced this issue Jun 17, 2015

Core: Change support.ownLast to support.ownFirst
jQuery.support.ownLast was the only support test that was supposed
to be false when it succeeded. It was confusing.

Fixes gh-2406
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 17, 2015

Member

PR: #2408

Member

mgol commented Jun 17, 2015

PR: #2408

mgol added a commit that referenced this issue Jun 22, 2015

Core: Change support.ownLast to support.ownFirst
jQuery.support.ownLast was the only support test that was supposed
to be false when it succeeded. It was confusing.

Fixes gh-2406
Closes gh-2408
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 22, 2015

Member

Closed via #2408.

Member

mgol commented Jun 22, 2015

Closed via #2408.

@mgol mgol closed this Jun 22, 2015

@mgol mgol removed this from the 3.0.0 milestone Nov 5, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Nov 5, 2015

Member

Clearing the milestone as we're not releasing compat after all and this change won't be applicable to code that has to support IE6/7.

Member

mgol commented Nov 5, 2015

Clearing the milestone as we're not releasing compat after all and this change won't be applicable to code that has to support IE6/7.

@mgol mgol added wontfix and removed Has Pull Request labels Nov 5, 2015

@markelog markelog removed the wontfix label Dec 22, 2015

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Dec 22, 2015

Member

@mzgol fyi, since we are releasing another compat, wonfix label removed

Member

markelog commented Dec 22, 2015

@mzgol fyi, since we are releasing another compat, wonfix label removed

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Dec 22, 2015

Member

Not compat, but regular 1.x. I added wontfix here because this issue doesn't matter for code soon to be dead. If it's included in your 1.12-stable branch, though, then removing wontfix is fine.

Member

mgol commented Dec 22, 2015

Not compat, but regular 1.x. I added wontfix here because this issue doesn't matter for code soon to be dead. If it's included in your 1.12-stable branch, though, then removing wontfix is fine.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Dec 22, 2015

Member

But, if you're removing the wontfix label, please remember to open the issue and assign the proper milestone...

Member

mgol commented Dec 22, 2015

But, if you're removing the wontfix label, please remember to open the issue and assign the proper milestone...

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Dec 22, 2015

Member

Not compat, but regular 1.x.

It is just a name change, so for me, it is a same thing.

But, if you're removing the wontfix label, please remember to open the issue and assign the proper milestone...

should be done in general

Member

markelog commented Dec 22, 2015

Not compat, but regular 1.x.

It is just a name change, so for me, it is a same thing.

But, if you're removing the wontfix label, please remember to open the issue and assign the proper milestone...

should be done in general

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Dec 22, 2015

Member

Not compat, but regular 1.x.

Apparently, for the team too, since we still use 1.x label

Member

markelog commented Dec 22, 2015

Not compat, but regular 1.x.

Apparently, for the team too, since we still use 1.x label

@mgol mgol added the wontfix label Jan 27, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.