The event module is listed twice in the modules dropdown on the QUnit test page #2437

Closed
mgol opened this Issue Jun 30, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@mgol
Member

mgol commented Jun 30, 2015

The event module is listed twice in the modules dropdown on the QUnit test page. This is probably because of

module( "event" );
.

@timmywil, any idea why it's written this way?

Screenshot:
screen shot 2015-06-30 at 16 18 16

@mgol mgol added the Build label Jun 30, 2015

@mgol mgol added this to the 3.0.0 milestone Jun 30, 2015

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jun 30, 2015

Member

We can just call that the "ready" module; it needed to be separated because the ready tests need to load synchronously in AMD mode.

Member

timmywil commented Jun 30, 2015

We can just call that the "ready" module; it needed to be separated because the ready tests need to load synchronously in AMD mode.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jun 30, 2015

Member

We can just call that the "ready" module

👍

Member

mgol commented Jun 30, 2015

We can just call that the "ready" module

👍

@timmywil timmywil self-assigned this Jun 30, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 1, 2015

Member

No matter which one of these event entries I choose, I still get the same event tests executed; the double entry doesn't appear in AMD mode, though. How is it all wired up?

Member

mgol commented Jul 1, 2015

No matter which one of these event entries I choose, I still get the same event tests executed; the double entry doesn't appear in AMD mode, though. How is it all wired up?

markelog added a commit to markelog/jquery that referenced this issue Aug 16, 2015

markelog added a commit to markelog/jquery that referenced this issue Sep 3, 2015

markelog added a commit to markelog/jquery that referenced this issue Sep 3, 2015

markelog added a commit to markelog/jquery that referenced this issue Sep 3, 2015

@markelog markelog closed this in 7aa46e0 Sep 7, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.