New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch property needs to be quoted in Android 2.3 #2478

Closed
mgol opened this Issue Jul 18, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Jul 18, 2015

Apparently Android 2.3 doesn't like a catch property and so it fails deferred tests completely since 84ccf26. We need to quote it as on the compat branch.

Do we have any way to ensure we don't change it back without turning on the JSHint es3 option? :/ Or maybe via JSCS? cc @rwaldron @markelog.

@mgol mgol added the Deferred label Jul 18, 2015

@mgol mgol self-assigned this Jul 18, 2015

@mgol mgol added this to the 3.0.0 milestone Jul 18, 2015

@mgol mgol removed their assignment Jul 18, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 18, 2015

Member

Or maybe we should just turn on the es3 option on master, preferably with a comment that Android 2.3 needs it.

Member

mgol commented Jul 18, 2015

Or maybe we should just turn on the es3 option on master, preferably with a comment that Android 2.3 needs it.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jul 18, 2015

Member

Probably easier to left a comment in the source code? As inline rule or just as a warning?

Member

markelog commented Jul 18, 2015

Probably easier to left a comment in the source code? As inline rule or just as a warning?

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 18, 2015

Member
Member

mgol commented Jul 18, 2015

@mgol mgol changed the title from catch needs to be accessed via the array syntax in Android 2.3 to catch property needs to be quoted in Android 2.3 Jul 18, 2015

@mgol mgol self-assigned this Jul 18, 2015

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jul 19, 2015

Member

there may be other reserved words that don't work as property names

Is there? Every reserved word should trigger such error, if that the case, then we should enable es3.

Member

markelog commented Jul 19, 2015

there may be other reserved words that don't work as property names

Is there? Every reserved word should trigger such error, if that the case, then we should enable es3.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 19, 2015

Member

Every reserved word should trigger such error

I didn't check all but at least catch, class & else trigger this error. They all work on Android 4.0.

Member

mgol commented Jul 19, 2015

Every reserved word should trigger such error

I didn't check all but at least catch, class & else trigger this error. They all work on Android 4.0.

mgol added a commit to mgol/jquery that referenced this issue Jul 19, 2015

Build: Acknowledge Android 2.3 is not ES5-compatible
Android 2.3 chokes on unquoted reserved words being used as property names
which was making Deferred tests not run.

Acknowledge the sad fact that Android 2.3 is not ES5-compliant browser
and enable the "es3" option in JSHint config.

Fixes gh-2478
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 19, 2015

Member

PR: #2481.

Member

mgol commented Jul 19, 2015

PR: #2481.

@mgol mgol removed the Needs review label Jul 19, 2015

@mgol mgol closed this in 1c59b30 Jul 20, 2015

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.