New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge compat #2484

Closed
csuwildcat opened this Issue Jul 20, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@csuwildcat

csuwildcat commented Jul 20, 2015

Hey there jQs,

I am going to be the point of contact for library compatibility Edge. Do you know the current compat ranges for jQuery, and any bugs that are blocking operational compat with Edge?

  • Daniel
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 20, 2015

Member

Hi @csuwildcat, thanks for reaching! I've recently added Edge to our support infrastructure, temporarily to the 2nd-grade periodic run instead of the main one until all issues are resolved.

There are mostly two issues:

  1. #2390 - We have a Sizzle PR (jquery/sizzle#341) from @jdalton. We'd love to not have to make all browsers suffer but until Edge fixes the bug we have to drop the document.documentMode guard in applying the workaround.
  2. #2389 - missing window.onfocusin. This is not critical but it will make jQuery use its own focusin/focusout emulation instead of the native one. We already do that for Chrome because of bugs in implementing those events (I don't know if Edge kept it's good IE implementation or replicated Chrome bugs there).

In http://swarm.jquery.org/job/942 you can see one more Edge failure, this is one box-sizing-related test that already passes in newer builds, it's just that BrowserStack has only a relatively old build, still named Spartan, where it was still an issue.

IMO everything else is fine.

Member

mgol commented Jul 20, 2015

Hi @csuwildcat, thanks for reaching! I've recently added Edge to our support infrastructure, temporarily to the 2nd-grade periodic run instead of the main one until all issues are resolved.

There are mostly two issues:

  1. #2390 - We have a Sizzle PR (jquery/sizzle#341) from @jdalton. We'd love to not have to make all browsers suffer but until Edge fixes the bug we have to drop the document.documentMode guard in applying the workaround.
  2. #2389 - missing window.onfocusin. This is not critical but it will make jQuery use its own focusin/focusout emulation instead of the native one. We already do that for Chrome because of bugs in implementing those events (I don't know if Edge kept it's good IE implementation or replicated Chrome bugs there).

In http://swarm.jquery.org/job/942 you can see one more Edge failure, this is one box-sizing-related test that already passes in newer builds, it's just that BrowserStack has only a relatively old build, still named Spartan, where it was still an issue.

IMO everything else is fine.

@csuwildcat

This comment has been minimized.

Show comment
Hide comment
@csuwildcat

csuwildcat Jul 20, 2015

I just did a quick review of the items you listed (knew about the focusin detection/polyfill one), and it seems like there's a good idea of what's wrong in each. Focusin is a bummer, and I will escalate that, but are any of these going to present hard stops for people, in your estimation?

csuwildcat commented Jul 20, 2015

I just did a quick review of the items you listed (knew about the focusin detection/polyfill one), and it seems like there's a good idea of what's wrong in each. Focusin is a bummer, and I will escalate that, but are any of these going to present hard stops for people, in your estimation?

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 20, 2015

Member

are any of these going to present hard stops for people, in your estimation?

No, I don't think anything here is a hard blocker. Fortunately we've never shipped the workaround for http://bugs.jquery.com/ticket/13936 in version that checked for document.documentMode, it was just on master so we're good. 👍

Member

mgol commented Jul 20, 2015

are any of these going to present hard stops for people, in your estimation?

No, I don't think anything here is a hard blocker. Fortunately we've never shipped the workaround for http://bugs.jquery.com/ticket/13936 in version that checked for document.documentMode, it was just on master so we're good. 👍

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 22, 2015

Member

@csuwildcat Is there anything else we can do here? If not, I'd rather move any further conversation about mentioned two bugs to them, i.e. to #2390 & #2389.

Member

mgol commented Jul 22, 2015

@csuwildcat Is there anything else we can do here? If not, I'd rather move any further conversation about mentioned two bugs to them, i.e. to #2390 & #2389.

@csuwildcat

This comment has been minimized.

Show comment
Hide comment
@csuwildcat

csuwildcat Jul 22, 2015

@mzgol no, this looks good. Now that I have the two relatively minor issues logged I can follow up on them separately from this overall compat confirmation. Thank you!

csuwildcat commented Jul 22, 2015

@mzgol no, this looks good. Now that I have the two relatively minor issues logged I can follow up on them separately from this overall compat confirmation. Thank you!

@csuwildcat csuwildcat closed this Jul 22, 2015

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.