Add basic tests for Android 2.3 on master, drop full support #2505

Closed
mgol opened this Issue Jul 28, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@mgol
Member

mgol commented Jul 28, 2015

jQuery 3.0.0 will include only basic support for Android 2.3, bigger non-critical workarounds like reliableMarginRight will be compat-only.

Those tests need to be written.

To not create further divergence between master & compat test files, I propose to create a separate android "module" with those basic tests. Thoughts?

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Jul 28, 2015

Member

To not create further divergence between master & compat test files, I propose to create a separate android "module" with those basic tests. Thoughts?

I like the idea, but would rather see a name like "basic" or "minimal" so we're not tied to a given client—the same suite might apply to e.g. jsdom or PhantomJS.

Member

gibson042 commented Jul 28, 2015

To not create further divergence between master & compat test files, I propose to create a separate android "module" with those basic tests. Thoughts?

I like the idea, but would rather see a name like "basic" or "minimal" so we're not tied to a given client—the same suite might apply to e.g. jsdom or PhantomJS.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 28, 2015

Member

I (...) would rather see a name like "basic" or "minimal" so we're not tied to a given client

Works for me. Good idea about jsdom & PhantomJS, btw, this might not be that hard to add once we have this.

Member

mgol commented Jul 28, 2015

I (...) would rather see a name like "basic" or "minimal" so we're not tied to a given client

Works for me. Good idea about jsdom & PhantomJS, btw, this might not be that hard to add once we have this.

mgol added a commit that referenced this issue Jul 29, 2015

mgol added a commit that referenced this issue Jul 29, 2015

mgol added a commit that referenced this issue Jul 29, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 30, 2015

Member

PR (in progress but I need feedback before I continue): #2509.

Member

mgol commented Jul 30, 2015

PR (in progress but I need feedback before I continue): #2509.

mgol added a commit that referenced this issue Aug 3, 2015

mgol added a commit that referenced this issue Aug 3, 2015

mgol added a commit that referenced this issue Aug 3, 2015

mgol added a commit that referenced this issue Aug 5, 2015

@mgol mgol closed this in 2c7e9c9 Sep 8, 2015

mgol added a commit that referenced this issue Sep 8, 2015

Tests: Backport basic tests from master
Commit 2c7e9c9 added the basic test suite; these are the only tests that
are now run on Android 2.3 on master. On compat we're keeping full Android 2.3
support for now but the tests and the testswarm basic run mode have been
cherry-picked anyway to reduce the divergence between branches.

(cherry-picked from 2c7e9c9)

Fixes gh-2505
Closes gh-2509
Refs gh-2483

@mgol mgol reopened this Sep 8, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 8, 2015

Member

This is not fixed until we reduce support as in the title. Only the first part (basic tests) have been finished.

Member

mgol commented Sep 8, 2015

This is not fixed until we reduce support as in the title. Only the first part (basic tests) have been finished.

mgol added a commit to mgol/jquery that referenced this issue Sep 8, 2015

Core: Reduce Android 2.3 support
Drop non-critical workarounds for Android 2.3.

Fixes gh-2505
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 8, 2015

Member

PR: #2581

Member

mgol commented Sep 8, 2015

PR: #2581

mgol added a commit to mgol/jquery that referenced this issue Sep 8, 2015

Core: Reduce Android 2.3 support
Drop non-critical workarounds for Android 2.3.

Fixes gh-2483
Fixes gh-2505

mgol added a commit to mgol/jquery that referenced this issue Sep 14, 2015

Ajax:Attributes:CSS:Manipulation: Reduce Android 2.3 support
Drop non-critical workarounds for Android 2.3.

Fixes gh-2483
Fixes gh-2505
Closes gh-2581

@mgol mgol closed this in #2581 Sep 14, 2015

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.