Don't expose jQuery.access #2513

Closed
mgol opened this Issue Jul 31, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@mgol
Member

mgol commented Jul 31, 2015

jQuery.access is public & undocumented, is there a reason we should keep it that way? We removed jQuery.swap (#2058), jQuery.buildFragment (#2224) & jQuery.domManip (#2225).

See also #2512.

@mgol mgol added this to the 3.0.0 milestone Aug 3, 2015

@mgol mgol self-assigned this Aug 3, 2015

@mgol mgol removed the Needs review label Aug 3, 2015

mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015

Core: Don't expose jQuery.access
jQuery.access was never documented, there is no need to keep it exposed.

Fixes gh-2513

mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015

Core: Don't expose jQuery.access
jQuery.access was never documented, there is no need to keep it exposed.

Fixes gh-2513
Closes gh-2524
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Aug 3, 2015

Member

PR: #2524

Member

mgol commented Aug 3, 2015

PR: #2524

@mgol mgol closed this in #2524 Aug 4, 2015

mgol added a commit that referenced this issue Aug 4, 2015

Core: Don't expose jQuery.access
jQuery.access was never documented, there is no need to keep it exposed.

Fixes gh-2513
Closes gh-2524

riichard added a commit to riichard/jquery that referenced this issue Sep 20, 2015

Core: Don't expose jQuery.access
jQuery.access was never documented, there is no need to keep it exposed.

Fixes gh-2513
Closes gh-2524

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016

@milesj

This comment has been minimized.

Show comment
Hide comment
@milesj

milesj Apr 20, 2016

This was unfortunate. $.access() was great for building our own getter/setter combo methods.

milesj commented Apr 20, 2016

This was unfortunate. $.access() was great for building our own getter/setter combo methods.

@milesj milesj referenced this issue in titon/toolkit Apr 20, 2016

Closed

Error $.access is not a function #167

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Apr 20, 2016

Member

Sorry for the inconvenience! I'd be willing to consider exposing this method (and documenting it) for plugins, but we don't like having public methods that aren't documented.

Member

timmywil commented Apr 20, 2016

Sorry for the inconvenience! I'd be willing to consider exposing this method (and documenting it) for plugins, but we don't like having public methods that aren't documented.

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.