New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose jQuery.acceptData #2555

Closed
jbedard opened this Issue Aug 23, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@jbedard
Contributor

jbedard commented Aug 23, 2015

Similar to the other "don't expose" cases. Is there any reason for this to be exposed and undocumented?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 23, 2015

Member

Hm, i guess one might argue that this function could be useful to plugin writers, but it seems we just should stop exposing it instead, then documenting it

Member

markelog commented Aug 23, 2015

Hm, i guess one might argue that this function could be useful to plugin writers, but it seems we just should stop exposing it instead, then documenting it

@markelog markelog added the Data label Aug 23, 2015

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Aug 24, 2015

Member

@arschmitz @scottgonzalez Do you use this in mobile/UI?

Member

timmywil commented Aug 24, 2015

@arschmitz @scottgonzalez Do you use this in mobile/UI?

@jbedard

This comment has been minimized.

Show comment
Hide comment
@jbedard

jbedard Aug 24, 2015

Contributor

Another option is to still expose it but use the internal var instead of jQuery.acceptData to save some bytes and not support overriding it. Today it is also copied into Data, so overriding it would be buggy anyway.

Contributor

jbedard commented Aug 24, 2015

Another option is to still expose it but use the internal var instead of jQuery.acceptData to save some bytes and not support overriding it. Today it is also copied into Data, so overriding it would be buggy anyway.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Aug 24, 2015

Member

@timmywil this is not used by either ui or mobile

Member

arschmitz commented Aug 24, 2015

@timmywil this is not used by either ui or mobile

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 24, 2015

Member

@timmywil this is not used by either ui or mobile

It seems we're good of stop exposing it, @jbedard would you like to send us a pr?

Member

markelog commented Aug 24, 2015

@timmywil this is not used by either ui or mobile

It seems we're good of stop exposing it, @jbedard would you like to send us a pr?

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Aug 24, 2015

Member

Another option is to still expose it but use the internal var instead of jQuery.acceptData to save some bytes and not support overriding it.

By "exposing" we mean putting it on the jQuery object so that it's accessible in the compiled version. If you just use AMD modules you can get to a lot of internal stuff already, we just don't guarantee the file hierarchy doesn't change: it might do even in a patch release.

Member

mgol commented Aug 24, 2015

Another option is to still expose it but use the internal var instead of jQuery.acceptData to save some bytes and not support overriding it.

By "exposing" we mean putting it on the jQuery object so that it's accessible in the compiled version. If you just use AMD modules you can get to a lot of internal stuff already, we just don't guarantee the file hierarchy doesn't change: it might do even in a patch release.

@timmywil timmywil removed the Needs review label Aug 24, 2015

jbedard added a commit to jbedard/jquery that referenced this issue Aug 25, 2015

Data: Don't expose jQuery.acceptData
jQuery.acceptData is an undocumented internal API that shouldn't be exposed.

Fixes gh-2555

@mgol mgol added this to the 3.0.0 milestone Aug 25, 2015

@mgol mgol closed this in 2242719 Sep 7, 2015

mgol added a commit that referenced this issue Sep 7, 2015

Data: Don't expose jQuery.acceptData
jQuery.acceptData is an undocumented internal API that shouldn't be exposed.

(cherry-picked from 2242719)

Fixes gh-2555

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.