Use dot notation for "throws" property #2571

Closed
markelog opened this Issue Sep 2, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@markelog
Member

markelog commented Sep 2, 2015

Ref http://bugs.jquery.com/ticket/12158
From there, (by @dmethvin) -

We'll leave this quoted fix in for 1.8 but will remove it in the next minor/major release.

Back then, YUICOMPRESSOR had version 1.4.7, now it is 2.4.8, will do with #2542, since jscs chokes on it

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 3, 2015

Member

I vaguely remember QUnit had to restore the raizes alias because of some problems with throws. Could you remind us what was that about, @jzaefferer?

Member

mgol commented Sep 3, 2015

I vaguely remember QUnit had to restore the raizes alias because of some problems with throws. Could you remind us what was that about, @jzaefferer?

@markelog markelog added the Ajax label Sep 7, 2015

@markelog markelog closed this in c9cf250 Sep 7, 2015

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Sep 7, 2015

Member

A little late, but: https://github.com/jquery/qunit/blob/1967b78eb8d9faba8091607b8bcc397aa014db2c/src/assert.js#L174-L179

Narwhal shouldn't matter, Closure Compiler might be okay with it by now, but I recommend testing with it.

Member

jzaefferer commented Sep 7, 2015

A little late, but: https://github.com/jquery/qunit/blob/1967b78eb8d9faba8091607b8bcc397aa014db2c/src/assert.js#L174-L179

Narwhal shouldn't matter, Closure Compiler might be okay with it by now, but I recommend testing with it.

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.