Offset: Fractions test fails in Chrome 45 #2590

Closed
Krinkle opened this Issue Sep 12, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@Krinkle
Member

Krinkle commented Sep 12, 2015

Two days ago, TestSwarm updated the jquery-core browser set from Chrome 43/44 to Chrome 44/45.

This revealed a test failure.

http://swarm.jquery.org/result/619430:

offset: fractions (see #7730 and #7885) (1, 1, 2)
Check top
Expected: 1000
Result: 999.984375

Looks like Chrome 45 is more precise than our tests expect.

@mgol mgol added the Offset label Sep 12, 2015

@mgol mgol added this to the 3.0.0 milestone Sep 12, 2015

@mgol mgol self-assigned this Sep 12, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 12, 2015

Member

Yeah, I've noticed it even before updating the browsers as I've seen it on Chrome locally but I wanted to be sure it's not just my machine. But thanks for the report anyway!

Member

mgol commented Sep 12, 2015

Yeah, I've noticed it even before updating the browsers as I've seen it on Chrome locally but I wanted to be sure it's not just my machine. But thanks for the report anyway!

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 14, 2015

Member

Actually, it seems Chrome 45 is less precise than older versions. I'll need to investigate further, I don't want to just decrease the test expectation without making sure this output is acceptable.

Member

mgol commented Sep 14, 2015

Actually, it seems Chrome 45 is less precise than older versions. I'll need to investigate further, I don't want to just decrease the test expectation without making sure this output is acceptable.

@mgol mgol referenced this issue Oct 12, 2015

Closed

Consistent swarm failures #2644

4 of 4 tasks complete
@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Oct 18, 2015

Member

@mzgol I'm going to take this one for a jqsummit project.

Member

dmethvin commented Oct 18, 2015

@mzgol I'm going to take this one for a jqsummit project.

@dmethvin dmethvin assigned dmethvin and unassigned mgol Oct 18, 2015

Queeniebee pushed a commit to Queeniebee/jquery that referenced this issue Oct 18, 2015

Queeniebee added a commit to Queeniebee/jquery that referenced this issue Oct 18, 2015

@dmethvin dmethvin closed this in 9f9e204 Oct 18, 2015

dmethvin added a commit that referenced this issue Oct 18, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.