Compat ajax tests are failing on Chrome 46 #2673

Closed
gibson042 opened this Issue Oct 23, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@gibson042
Member

gibson042 commented Oct 23, 2015

http://swarm.jquery.org/result/728285

The issue identified in http://bugs.jquery.com/ticket/14683#comment:12 has apparently been resolved as of Chrome 46, so passing invalid URLs to jQuery.ajax now creates a state where no exception is thrown and our callback will never be invoked.

@gibson042 gibson042 self-assigned this Oct 23, 2015

@gibson042 gibson042 added this to the 3.0.0 milestone Oct 23, 2015

gibson042 added a commit to gibson042/jquery that referenced this issue Oct 23, 2015

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Oct 23, 2015

Member

Closed by 0a6e1c4.

Member

gibson042 commented Oct 23, 2015

Closed by 0a6e1c4.

@gibson042 gibson042 closed this Oct 23, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jan 11, 2016

Member

@gibson042 I see this didn't make it into 1.12.0. Is it no longer needed? If so, a milestone should be cleared & the issue marked as wontfix.

Member

mgol commented Jan 11, 2016

@gibson042 I see this didn't make it into 1.12.0. Is it no longer needed? If so, a milestone should be cleared & the issue marked as wontfix.

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Jan 12, 2016

Member

0a6e1c4 is a cleaner approach and should have made it in, but if we're not failing tests then I guess it's no big deal.

Member

gibson042 commented Jan 12, 2016

0a6e1c4 is a cleaner approach and should have made it in, but if we're not failing tests then I guess it's no big deal.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jan 12, 2016

Member

Yeah, tests are passing. I'm clearing the milestone then.

Member

mgol commented Jan 12, 2016

Yeah, tests are passing. I'm clearing the milestone then.

@mgol mgol removed this from the 3.0.0 milestone Jan 12, 2016

@mgol mgol added the Works For Me label Jan 12, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.