New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css('animation-iteration-count', 5) doesn't apply style to element #2792

Closed
ufologist opened this Issue Dec 30, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ufologist
Contributor

ufologist commented Dec 30, 2015

When I use css('animation-iteration-count', 5) I expect element has style="-webkit-animation-iteration-count: 5;" (this vendor prefix is just a example), but it doesn't.

So I debug jQuery.js, I found when I use css('animation-iteration-count', 5) actually become style[ 'WebkitAnimationIterationCount' ] = 5 + 'px'.
Browser consider it a illegal value, because animation-iteration-count only accept infinite | <number>, so this style don't have effect.

This is a reproduceBug demo

So that cssNumber shoud add animationIterationCount property to prevent automatically add "px" to the value.

@ufologist

This comment has been minimized.

Show comment
Hide comment
@ufologist

ufologist Dec 31, 2015

Contributor

Goto #2793 to see how to fix that

Contributor

ufologist commented Dec 31, 2015

Goto #2793 to see how to fix that

@ufologist ufologist closed this Dec 31, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Dec 31, 2015

Member

Reopening, this shouldn't have been closed.

Member

mgol commented Dec 31, 2015

Reopening, this shouldn't have been closed.

@mgol mgol reopened this Dec 31, 2015

ufologist added a commit to ufologist/jquery that referenced this issue Jan 4, 2016

@mgol mgol added this to the 1.12/2.2 milestone Jan 7, 2016

@mgol mgol added the CSS label Jan 7, 2016

@mgol mgol self-assigned this Jan 7, 2016

@mgol mgol closed this in df822ca Jan 7, 2016

mgol added a commit that referenced this issue Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.