Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery.now #2959

Closed
markelog opened this issue Feb 29, 2016 · 6 comments
Closed

Deprecate jQuery.now #2959

markelog opened this issue Feb 29, 2016 · 6 comments
Assignees
Milestone

Comments

@markelog
Copy link
Member

@markelog markelog commented Feb 29, 2016

It's already just a reference to Date.now

@markelog markelog added this to the 3.1.0 milestone Feb 29, 2016
@mgol
Copy link
Member

@mgol mgol commented Feb 29, 2016

👍

@markelog markelog added the Core label Mar 3, 2016
@dustinpoissant
Copy link

@dustinpoissant dustinpoissant commented Mar 17, 2016

Or new Date().getTime(); or Date.now(). There is no need for this in jQuery.

@ShashankaNataraj
Copy link
Contributor

@ShashankaNataraj ShashankaNataraj commented Jul 9, 2016

@dustinpoissant @mgol Can do this and submit a PR?

@mgol
Copy link
Member

@mgol mgol commented Jul 9, 2016

@ShashankaNataraj Sure. Just remember to move jQuery.now to src/deprecated.js and change all current uses of jQuery.now to Date.now.

Note that we scheduled it for 3.2.0 and we'll most likely want to release 3.1.1 before that so your PR may not be immediately merged even if ready.

@markelog
Copy link
Member Author

@markelog markelog commented Jul 9, 2016

Also pr for doc changes to github.com/jquery/api.jquery.com would also be appreciated

@ShashankaNataraj
Copy link
Contributor

@ShashankaNataraj ShashankaNataraj commented Jul 9, 2016

@mgol @markelog Thanks! Will do!

@dmethvin dmethvin mentioned this issue Aug 14, 2016
5 of 8 tasks complete
@timmywil timmywil modified the milestones: 3.2.0, 3.3.0 Mar 6, 2017
@timmywil timmywil self-assigned this Mar 27, 2017
This was referenced Apr 2, 2017
@timmywil timmywil added the Blocker label Jun 19, 2017
timmywil added a commit to timmywil/jquery that referenced this issue Dec 11, 2017
@timmywil timmywil mentioned this issue Dec 11, 2017
4 of 4 tasks complete
@timmywil timmywil closed this in 909e0c9 Jan 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants