New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`jQuery.Event( src )` cannot require `src.target` #3139

Closed
dmethvin opened this Issue Jun 2, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@dmethvin
Member

dmethvin commented Jun 2, 2016

If you construct a jQuery.Event( src ) using something that has src.type, the 3.0 code will die if there is not an src.target property. jQuery Mobile uses a pattern where they construct an object and then set properties like target afterwards, which was allowed by 1.x/2.x, so we need to fix this as a regression.

@dmethvin dmethvin added this to the 3.0.0 milestone Jun 2, 2016

@dmethvin dmethvin self-assigned this Jun 2, 2016

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin
Member

dmethvin commented Jun 2, 2016

dmethvin added a commit to dmethvin/jquery that referenced this issue Jun 2, 2016

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jun 2, 2016

Member

@dmethvin ah thanks yeah i was having trouble figuring out exactly where this error was coming from

Member

arschmitz commented Jun 2, 2016

@dmethvin ah thanks yeah i was having trouble figuring out exactly where this error was coming from

@dmethvin dmethvin closed this in 2df590e Jun 3, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.