Source file location in jQuery CDN .map file is incorrect #3260

Closed
dmethvin opened this Issue Aug 2, 2016 · 2 comments

Projects

None yet

2 participants

@dmethvin
Member
dmethvin commented Aug 2, 2016 edited

At some point in the recent past, Chrome added the ability to manually associate a map file with minified source. For people using the jQuery CDN, this would optimistically mean they could right click on the file in dev tools and for example associate https://code.jquery.com/jquery-3.1.0.min.map with the jQuery 3.1.0 minified file. However, that map file refers back to plain old jquery.js as the original source, which is our frozen-in-time 1.11 version. It should refer to jquery-3.1.0.min.js.

The release process should ensure the file name matches the one on the CDN so that it could be manually associated for debugging.

Map files are so lame.

@dmethvin
Member
dmethvin commented Aug 5, 2016

Also to be clear, the current map file name is correct for the Google CDN since they deliver their copy with the name jquery.js. The jQuery and Microsoft CDNs include the version number in the file name, so they require a physically different map file with the version-specific file names.

@timmywil timmywil added the Build label Aug 5, 2016
@timmywil timmywil added this to the 3.1.1 milestone Aug 5, 2016
@dmethvin dmethvin was assigned by timmywil Aug 15, 2016
@dmethvin
Member
dmethvin commented Aug 17, 2016 edited

Just showing my work here so I can come back to it when I get a chance.

jQuery 1.12.0 is where this regressed. It looks like the code to rename the references in the map file is [still there](https://github.com/jquery/jquery/blob/3bbcce68d7b8b8a7a2164a0f7a280ae9daf70b5c/build/release/cdn.js#L41-L48 but the names of the versioned files aren't correct in the jQuery CDN or the Microsoft CDN.

@dmethvin dmethvin added a commit to dmethvin/jquery that referenced this issue Sep 19, 2016
@dmethvin dmethvin Build: Make sourcemap updates in two .replace() passes
Fixes gh-3260
94af706
@dmethvin dmethvin closed this in 37f1da6 Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment