Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery.holdReady #3288

Closed
gibson042 opened this issue Aug 22, 2016 · 3 comments
Closed

Deprecate jQuery.holdReady #3288

gibson042 opened this issue Aug 22, 2016 · 3 comments
Milestone

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Aug 22, 2016

Suggested in #1778 (comment) and decided in #2850 (comment) . Gap noticed in #3287.

@gibson042 gibson042 added the Core label Aug 22, 2016
@gibson042 gibson042 added this to the 3.2.0 milestone Aug 22, 2016
@dmethvin dmethvin mentioned this issue Aug 22, 2016
5 of 8 tasks complete
@dmethvin
Copy link
Member

@dmethvin dmethvin commented Aug 22, 2016

Added to the API list as well.

@kumarmj
Copy link
Contributor

@kumarmj kumarmj commented Aug 29, 2016

I want to work on this issue, please inform me what to do of test/data/readywaitloader.js & test/data/readywait.html. The checklist of me goes like this -

  • Move jQuery.holdReady() from src/core/ready.js to src/deprecated.js
  • Remove jQuery.holdReady() from src/core/ready-no-deferred.js
  • Open a migrate issue
@gibson042
Copy link
Member Author

@gibson042 gibson042 commented Aug 31, 2016

test/data/jquery-1.9.1.js should be left alone, as should the other test files. Other than that, 👍.

@timmywil timmywil closed this in bd984f0 Feb 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.