GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutation of the timer list inside a timer callback can affect the timer index, resulting in skipped callbacks.
Effects: Reference issues
but is the animation 'C' of the test case not being skipped after the commit? I think even the #3497 has to be fixed for it to work. Is what I am assuming correct ?
Good catch, @preethi26.
I really don't understand the difference between both the issues #3503 and #3497. Could you please clear it for me ?
#3497 is more general, covering not just callback skips (#3503) but also double-callbacks of new animations. It was my intent to fix the former immediately, but the code doing so was lost somewhere along the development of PR #3496.
@gibson042, So shouldn't the fix for #3497 fix #3503? Is there any reason for them to be separate ?
It's likely that they will now be fixed together.
Pushing to 3.3.