New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly detect attachment of Shadow DOM elements #3504
Closed
Comments
Yes to going forward and investigating, but we may scrap it later depending on how involved this gets. |
As noted in the meeting, we'd probably benefit from an internal |
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 14, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
2 tasks
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 14, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 14, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 15, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 16, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 16, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Feb 28, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Mar 2, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Mar 2, 2018
This change replaces the use of contains to check for attachment by isAttached function Ref jquerygh-3504
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Mar 5, 2018
Allow isAttached to check shadow DOM for attachment. This change allows isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode() Ref jquerygh-3504, jquerygh-3977
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Mar 26, 2018
Allow isAttached to check shadow DOM for attachment. This change allows isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode() Ref jquerygh-3504, jquerygh-3977
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Apr 12, 2018
Allow isAttached to check shadow DOM for attachment. This change allows isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode() Ref jquerygh-3504, jquerygh-3977
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Apr 13, 2018
Allow isAttached to check shadow DOM for attachment. This change allows isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode() Ref jquerygh-3504, jquerygh-3977
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Apr 13, 2018
Allow isAttached to check shadow DOM for attachment. This change allows isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode() Ref jquerygh-3504, jquerygh-3977
SaptakS
added a commit
to SaptakS/jquery
that referenced
this issue
Sep 24, 2018
Allow isAttached to check shadow DOM for attachment. This change allows isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode() Ref jquerygh-3504, jquerygh-3977
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are a few places where we check document attachment with
jQuery.contains( elem.ownerDocument, elem )
(isHiddenWithinTree
for show/hide,curCSS
for inline style fallback,buildFragment
/domManip
/remove
/jQuery.clone
for managing script evaluation during DOM manipulation), all of which fail inside Shadow DOM:We should investigate the cost of a remedy (e.g., a Shadow-DOM-compatible
isAttached( elem )
function).The text was updated successfully, but these errors were encountered: