New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery core functions are failing with custom jQuery build without Sizzle engine in some cases #3593

Closed
kolardavid opened this Issue Mar 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@kolardavid

kolardavid commented Mar 27, 2017

Description

In manipulationTarget() in jQuery library, there is expression searching for tbody tag inside table using code jQuery( ">tbody", elem ). This works fine with full jQuery library, however, when Sizzle selector engine is stripped (in custom builds), this statement fails, because it is jQuery specific selector.

My proposal is to change this statement to jQuery(elem).children( "tbody" ).

Link to test case

Test case wouldn't show this bug, because it has to be made with custom jQuery build without Sizzle engine.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Mar 27, 2017

Member

Yup! This used to be a native call to getElementsByTagName. I've added a note to run tests for custom builds to the release checklist, which I thought I had added before.

Member

timmywil commented Mar 27, 2017

Yup! This used to be a native call to getElementsByTagName. I've added a note to run tests for custom builds to the release checklist, which I thought I had added before.

@timmywil timmywil added this to the 3.3.0 milestone Mar 27, 2017

@timmywil timmywil self-assigned this Mar 27, 2017

@gibson042 gibson042 changed the title from jQuery core functions are failing with custom jQuery build without Sizzle engine in come cases to jQuery core functions are failing with custom jQuery build without Sizzle engine in some cases Jul 31, 2017

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jan 8, 2018

Member

Fixed by #3916

Member

timmywil commented Jan 8, 2018

Fixed by #3916

@timmywil timmywil closed this Jan 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.