Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a memory problem about deferred in 3.x #3606

Closed
houfeng0923 opened this issue Apr 2, 2017 · 1 comment
Closed

a memory problem about deferred in 3.x #3606

houfeng0923 opened this issue Apr 2, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@houfeng0923
Copy link

@houfeng0923 houfeng0923 commented Apr 2, 2017

Description

When our project upgraded to jQuery3.2.1 (from 2.2.4), we found a memory leak about Deferred in jQuery3.x . the promise.then method does not release the handler & handler Closure .
it work well in jQuery2.x and native Promise in chrome .

look at the following case:

Link to test case

http://plnkr.co/edit/DpMkLV2mqzwlX4Ruuk7i

image

image

@houfeng0923 houfeng0923 changed the title a memory problem about deferred in jQuery3.x a memory problem about deferred in 3.x Apr 3, 2017
@timmywil timmywil removed the Needs review label Apr 10, 2017
@timmywil timmywil added this to the 3.3.0 milestone Apr 10, 2017
@jbedard jbedard self-assigned this May 1, 2017
@jbedard
Copy link
Contributor

@jbedard jbedard commented May 4, 2017

Here's a version with non-minified jQuery: https://plnkr.co/edit/SE4DMFg8g3SGqDdhxCXx

big-deferred

jbedard added a commit to jbedard/jquery that referenced this issue May 4, 2017
jbedard added a commit to jbedard/jquery that referenced this issue May 5, 2017
jbedard added a commit to jbedard/jquery that referenced this issue May 9, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Jun 9, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Jun 13, 2017
jbedard added a commit to jbedard/jquery that referenced this issue Jun 14, 2017
gibson042 added a commit that referenced this issue Jun 20, 2017
mvilliger added a commit to BSI-Business-Systems-Integration-AG/org.eclipse.scout.docs that referenced this issue May 2, 2018
hubot pushed a commit to eclipse/scout.rt that referenced this issue May 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.