Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Cannot set property "grid-column-start" using .css() #4007
Thanks for the report (and a test case!). This is because, unfortunately, jQuery adds the
We keep a blacklist of CSS properties that shouldn't be getting this treatment:
We'll need to add Grid properties with number values there. Would you like to submit a PR to add this value (and perhaps more Grid-related ones)?
Before a fixed jQuery version arrives you can workaround this locally by:
jQuery.cssNumber.gridColumnStart = true;
See a fixed JSFiddle: https://jsfiddle.net/j15q5tzg/42/
Yes, I meant “pull request”, we often shorten it to PR. There’s no hurry so next week is totally fine! Let us know if you can’t find time or if you have any questions about how to submit a PR for this issue. We’ll happily guide you through the contribution process. Thanks! -- Michał Gołębiowski-Owczarek
I finally got around to compiling the CSS grid properties that need to be added.
I'm not sure if I need to update the unit test. The current unit test doesn't seem to have any specific cases for any of the current list of special-case CSS properties.
@enbo Could you submit a PR with your changes so that we can discuss them there?
The list looks good at first sight. As for the tests, we do have a few of assertions, see:
You could add the grid ones to the test. You'll need to check for grid support first, similarly to how