New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add license in GitHub settings #4039

Closed
fedir opened this Issue Apr 15, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@fedir

fedir commented Apr 15, 2018

Please add license in GitHub settings of the repository.

Currently, GitHub could not identify Your project licence, and it's not shown in interface, and not available via API also.

Ref : https://help.github.com/articles/adding-a-license-to-a-repository/

@mgol

This comment has been minimized.

Member

mgol commented Apr 15, 2018

Thanks for the report. We do have a license in our repository: https://github.com/jquery/jquery/blob/master/LICENSE.txt. It seems GitHub doesn't like the txt extension. I guess we could remove the extension, most repos I've seen don't use one or use md.

@dmethvin

This comment has been minimized.

Member

dmethvin commented Apr 15, 2018

The package.json also specifies license: "MIT". I'm fine with removing the .txt or changing to .md.

@fedir

This comment has been minimized.

fedir commented Apr 15, 2018

Hi !

I just get the answer from GitHub support team. Basically, GitHub uses automatic license detector : https://github.com/benbalter/licensee

I just installed it locally and get following results :

bundle exec bin/licensee detect https://github.com/jquery/jquery --remote --license mit
License:        
Matched files:  LICENSE.txt, package.json
LICENSE.txt:
  Content hash:  683d5d6a7caa50053354cadd3a71744de78e1904
  Attribution:   Copyright JS Foundation and other contributors, https://js.foundation/
  License:       
  Closest licenses:
    MIT similarity:      79.48%
    NCSA similarity:     69.84%
    BSL-1.0 similarity:  59.44%
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     MIT
Comparing to MIT License:
Input Length:      1514
License length:    1019
Similarity:      79.48%
diff --git a/LICENSE b/LICENSE
index ce3f035..ec7b26e 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,14 +1,20 @@
{+this software consists of voluntary contributions made by many individuals. for+}
{+exact contribution history, see the revision history available at+}
{+https://github.com/jquery/jquery the following license applies to all parts of+}
{+this software except as documented below:+} permission is hereby granted, free of
charge, to any person obtaining a copy of this software and associated
documentation files the "software" , to deal in the software without
restriction, including without limitation the rights to use, copy, modify,
merge, publish, distribute, sublicense, and/or sell copies of the software, and
to permit persons to whom the software is furnished to do so, subject to the
following conditions: the above copyright notice and this permission notice
shall be included in all copies or substantial portions of the software. the
software is provided "as is", without warranty of any kind, express or implied,
including but not limited to the warranties of merchantability, fitness for a
particular purpose and noninfringement. in no event shall the authors or
copyright holders be liable for any claim, damages or other liability, whether
in an action of contract, tort or otherwise, arising from, out of or in
connection with the software or the use or other dealings in the software. {+all+}
{+files located in the node modules and external directories are externally+}
{+maintained libraries used by this software which have their own licenses; we+}
{+recommend you read them, as their terms may differ from the terms above.+}

All of the sections surrounded by {+ and +} are additions that that tool detected. GitHub has 98% confidence requirement, so with those changes GitHub not meeting that threshold to detect this license.

If the project removes those additions, then the license will be detected properly.

Of course, it's author's and community choice, which version of license the project should use.

@dmethvin

This comment has been minimized.

Member

dmethvin commented Apr 16, 2018

I'm fine with making the changes although we should bring @kborchers in for specific changes to the LICENSE.txt file to be sure there are no legal issues. I see the same was done in the ESLint repo.

Note that the package.json file is also very clear that the license is MIT, being that it has "license": "MIT" right there.

@kborchers

This comment has been minimized.

Member

kborchers commented Apr 16, 2018

@dmethvin This is a much larger change than the one done in ESLint where they removed one minor "ESLint" line at the beginning. That said, in my opinion we can remove lines 3-11 without issue if the team would like to do that. I'm not sure if it will get us close enough for GitHub to be satisfied though. The last lines can not be removed as they define things that may not fall under the MIT license and that section is referenced from our CLA.

@kborchers

This comment has been minimized.

Member

kborchers commented Apr 16, 2018

Thinking on this a bit more, since the jQuery project is not defining other content that is licensed differently other than the node_modules and external directories, we may be able to remove that but I will need to check with legal and get back to you ASAP.

@dmethvin

This comment has been minimized.

Member

dmethvin commented May 14, 2018

Fixed by #4041

@dmethvin dmethvin closed this May 14, 2018

@dmethvin dmethvin added this to the 3.4.0 milestone May 14, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.