New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 7 fails dimension SVG tests #4155

Closed
jbedard opened this Issue Aug 12, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@jbedard
Contributor

jbedard commented Aug 12, 2018

It seems as if this iOS/safari version ignores box-sizing:border-box when the width attribute is used (<svg width="100" style="box-sizing:border-box">), unlike the width style (<svg style="width:100px; box-sizing:border-box">).

The failing tests could easily be updated to put the sizing in the style attribute. But maybe this is also a real bug worth fixing? Seems to only occur with Safari in iOS7 (iPhone 5).

See http://swarm.jquery.org/result/2886392

@jbedard

This comment has been minimized.

Show comment
Hide comment
@jbedard

jbedard Aug 13, 2018

Contributor

Decided we'll just fix the test since this only occurs on one old iOS version and this is not the purpose of the test.

Contributor

jbedard commented Aug 13, 2018

Decided we'll just fix the test since this only occurs on one old iOS version and this is not the purpose of the test.

jbedard added a commit to jbedard/jquery that referenced this issue Aug 13, 2018

Tests: use width style instead of SVG width attribute
The SVG width attribute seems to not support border-box in iOS7.

Closes jquerygh-4155

jbedard added a commit to jbedard/jquery that referenced this issue Aug 13, 2018

Tests: use width style instead of SVG width attribute
The SVG width attribute seems to not support border-box in iOS7.

Closes jquerygh-4155

jbedard added a commit that referenced this issue Aug 21, 2018

Tests: use width style instead of SVG width attribute (#4157)
The SVG width attribute seems to not support border-box in iOS7.

Closes gh-4155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment