New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomodule attribute is not respected on scripts with sources #4281

Closed
mgol opened this Issue Jan 17, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@mgol
Copy link
Member

mgol commented Jan 17, 2019

Description

PR #3869 added support for <script type="module"> & some support for the nomodule attribute but with no tests for nomodule and with the attribute only respected on inline scripts.

Ref #3871

Link to test case

http://plnkr.co/edit/rZJmEFJIpPOHDMNJUdxz?p=preview

In modern browsers you should see PASS, instead you'll see FAIL: 2, indicating 2 out of 4 scripts get executed; those are the src-based scripts.

@mgol mgol added this to the 3.4.0 milestone Jan 17, 2019

@mgol mgol self-assigned this Jan 17, 2019

mgol added a commit to mgol/jquery that referenced this issue Jan 17, 2019

Manipulation: Respect script nomodule attribute in DOM manipulation
PR jquery#3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.

Fixes jquerygh-4281
Ref jquerygh-3871
Ref jquerygh-3869
@mgol

This comment has been minimized.

Copy link
Member Author

mgol commented Jan 17, 2019

PR: #4282

@mgol mgol closed this in #4282 Jan 21, 2019

mgol added a commit that referenced this issue Jan 21, 2019

Manipulation: Respect script nomodule attribute in DOM manipulation
PR #3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.

Fixes gh-4281
Closes gh-4282
Ref gh-3871
Ref gh-3869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment