Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery 3.4 TypeError: e.getRootNode is not a function #4356

Closed
dmifedorenko opened this issue Apr 16, 2019 · 10 comments
Closed

jQuery 3.4 TypeError: e.getRootNode is not a function #4356

dmifedorenko opened this issue Apr 16, 2019 · 10 comments
Assignees
@mgol
Labels
Blocker Bug Core Has Pull Request
Milestone
3.4.1

Comments

@dmifedorenko
Copy link

Hello.

We just update jQuery from 3.3.1 to 3.4 and get some errors only on iOS 10.x.

Stack trace:
TypeError: TypeError: e.getRootNode is not a function. (In 'e.getRootNode(ae)', 'e.getRootNode' is undefined) oe@https://www.100sp.ru/bower/jquery/dist/jquery.min.js:2:35785 we@https://www.100sp.ru/bower/jquery/dist/jquery.min.js:2:38549 parseHTML@https://www.100sp.ru/bower/jquery/dist/jquery.min.js:2:83573 init@https://www.100sp.ru/bower/jquery/dist/jquery.min.js:2:25056 k@https://www.100sp.ru/bower/jquery/dist/jquery.min.js:2:963 s@https://www.100sp.ru/static/jquery-ui/1.12.1/jquery-ui.min.js:6:2339 https://www.100sp.ru/static/jquery-ui/1.12.1/jquery-ui.min.js:10:18498 https://www.100sp.ru/static/jquery-ui/1.12.1/jquery-ui.min.js:6:74 global code@https://www.100sp.ru/static/jquery-ui/1.12.1/jquery-ui.min.js:6:84

Examples of top user agents with this error:

Mozilla/5.0 (iPhone; CPU iPhone OS 10_2_1 like Mac OS X) AppleWebKit/602.4.6 (KHTML, like Gecko) Version/10.0 Mobile/14D27 Safari/602.1 422
Mozilla/5.0 (iPhone; CPU iPhone OS 10_2 like Mac OS X) AppleWebKit/602.3.12 (KHTML, like Gecko) Version/10.0 Mobile/14C92 Safari/602.1 174
Mozilla/5.0 (iPhone; CPU iPhone OS 10_2_1 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) GSA/21.1.139288856 Mobile/14D27 Safari/600.1.4 98
Mozilla/5.0 (iPhone; CPU iPhone OS 10_1_1 like Mac OS X) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0 Mobile/14B100 Safari/602.1 53
Mozilla/5.0 (iPhone; CPU iPhone OS 10_1 like Mac OS X) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0 Mobile/14B72 Safari/602.1 31
Mozilla/5.0 (iPhone; CPU iPhone OS 10_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) GSA/64.0.223374052 Mobile/14C92 Safari/602.1 22
Mozilla/5.0 (iPhone; CPU iPhone OS 10_2 like Mac OS X) AppleWebKit/602.3.12 (KHTML, like Gecko) Mobile/14C92 sp-mobile-app 20
Mozilla/5.0 (iPhone; CPU iPhone OS 10_1_1 like Mac OS X) AppleWebKit/602.2.14 (KHTML, like Gecko) Mobile/14B100 sp-mobile-app 19
Mozilla/5.0 (iPhone; CPU iPhone OS 10_2_1 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) CriOS/71.0.3578.89 Mobile/14D27 Safari/602.1 18
Mozilla/5.0 (iPhone; CPU iPhone OS 10_1_1 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) CriOS/67.0.3396.87 Mobile/14B100 Safari/602.1 17
Mozilla/5.0 (iPhone; CPU iPhone OS 10_2 like Mac OS X) AppleWebKit/602.3.12 (KHTML, like Gecko) Mobile/14C92 13
Mozilla/5.0 (iPhone; CPU iPhone OS 10_0_1 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Version/10.0 Mobile/14A403 Safari/602.1 12
Mozilla/5.0 (iPad; CPU OS 10_1_1 like Mac OS X) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0 Mobile/14B100 Safari/602.1 11
Mozilla/5.0 (iPhone; CPU iPhone OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Version/10.0 Mobile/14A456 Safari/602.1 9
Mozilla/5.0 (iPad; CPU OS 10_2 like Mac OS X) AppleWebKit/602.3.12 (KHTML, like Gecko) Version/10.0 Mobile/14C92 Safari/602.1 8

As you can see where are no Android and desktop browsers. Looks like this is problem in jquery and not in our own code. Can you check this issue please?
@rpellerin
Copy link

I'm affected as well. Any update on this? Thanks.

@mgol
Copy link
Member

mgol commented Apr 16, 2019

Can you provide a test case on JS Bin as the issue template requested? Thanks!

@dmifedorenko
Copy link
Author

No, I cant. The source code of my site is huge and I have no device with iOS 10.x

Can you just check calls of getRootNode inside new version?

Looks like bug relative to fresh changes #3996

@mgol
Copy link
Member

mgol commented Apr 16, 2019

The relevant code lines: https://github.com/jquery/jquery/blob/3.4.0/src/core/isAttached.js#L14-L19.

I think the problem is that iOS 10.0 supports Element#attachShadow but it doesn't support Element#getRootNode. It's hard for us to test it as our test run only on latest version of each iOS version that we test and iOS 10.3 does support getRootNode. I'd expect this test case to fail in iOS 10.0-10.2: https://jsbin.com/sohacog/1/edit?html,js but I have no way of making sure it does. I think changing the documentElement.attachShadow check to documentElement.getRootNode should help but it'd be worth verifying before we apply the change.

Does anyone has access to iOS 10.0, 10.1 or 10.2? If you do, can you:

  1. Check if https://output.jsbin.com/sohacog/1 displays FAIL there.
  2. Download https://code.jquery.com/jquery-3.4.0.js, swap documentElement.attachShadow for documentElement.getRootNode and check if the above test case now succeeds with such a modified jQuery copy?

@mgol mgol added this to the 3.4.1 milestone Apr 16, 2019
@mgol
Copy link
Member

mgol commented Apr 16, 2019

Note to self: land the relevant patch only on 3.4-stable as we're not going to support iOS <10.3 in jQuery 4.0.

@dmifedorenko
Copy link
Author

I can deploy patched jQuery version tomorrow and check JS errors on our site.

We collect and send JS errors to backend, and I saw about 1.5k entries with "e.getRootNode is not a function" every day.

@mgol
Copy link
Member

mgol commented Apr 16, 2019 •
edited
Loading

I've noticed latest Xcode on macOS Mojave allows to install an iOS 10.0 emulator (in the past it didn't let you reach that far to the past, I think) so I installed that & run my test case and it failed, indeed. I tested the rename that I suggested and it passed. I'll submit a PR with the fix soon.

@mgol mgol mentioned this issue Apr 16, 2019
Closed
mgol added a commit to mgol/jquery that referenced this issue Apr 16, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
3a80041 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes jquerygh-4356
mgol added a commit to mgol/jquery that referenced this issue Apr 16, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
82ec0b0 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes jquerygh-4356
@mgol mgol mentioned this issue Apr 16, 2019
Merged
2 tasks
@mgol
Copy link
Member

mgol commented Apr 16, 2019

PR: #4360

mgol added a commit to mgol/jquery that referenced this issue Apr 17, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
ad09efa 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes jquerygh-4356
@mgol mgol self-assigned this Apr 17, 2019
mgol added a commit to mgol/jquery that referenced this issue Apr 23, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
4f115eb 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes jquerygh-4356
mgol added a commit to mgol/jquery that referenced this issue Apr 24, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
db75f80 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes jquerygh-4356
@mgol mgol mentioned this issue Apr 28, 2019
Closed
mgol added a commit to mgol/jquery that referenced this issue Apr 29, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
90da3b3 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes jquerygh-4356
mgol added a commit that referenced this issue Apr 29, 2019
@mgol
Core: Make isAttached work with iOS 10.0-10.2
7dddb19 
The test for Shadow DOM v1 support has been changed to rely on the presence of
`documentElement.getRootNode` as iOS 10.0-10.2 supports `attachShadow` but
doesn't support `getRootNode`.

No new test is necessary - iOS 10.0 fails lots of our test suite because of
this bug.

Fixes gh-4356
Closes gh-4360
@mgol
Copy link
Member

mgol commented Apr 29, 2019

Fixed by 7dddb19.

@mgol mgol closed this as completed Apr 29, 2019
@mgol mgol mentioned this issue May 1, 2019
Closed
@timmywil
Copy link
Member

timmywil commented May 1, 2019

jQuery 3.4.1 has been released! https://blog.jquery.com/2019/05/01/jquery-3-4-1-triggering-focus-events-in-ie-and-finding-root-elements-in-ios-10/

@timbutler timbutler mentioned this issue May 27, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Blocker Bug Core Has Pull Request
Milestone
3.4.1
Development

No branches or pull requests
4 participants
@timmywil @mgol @dmifedorenko @rpellerin