Safari 16 crashes on in-template DOM manipulation #5147
Comments
|
I made a repository if you like to test it without fiddler. If you change this line to use the local jquery file |
mgol
added
the
Discuss in Meeting
timmywil
removed
the
Discuss in Meeting
mgol
changed the title
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 14, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains`. As it turns out, we don't need to query the supposed container `documentElement` if it has the `Node.DOCUMENT_NODE` (9) `nodeType`; we can call `.contains()` directly on the `document`. That avoids the crash. Fixes jquerygh-5147
2 tasks
mgol
added a commit
that referenced
this issue
Nov 14, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains`. As it turns out, we don't need to query the supposed container `documentElement` if it has the `Node.DOCUMENT_NODE` (9) `nodeType`; we can call `.contains()` directly on the `document`. That avoids the crash. Fixes gh-5147 Closes gh-5158
|
Reopening until the fix lands in Sizzle and - then - on |
mgol
added a commit
to mgol/sizzle
that referenced
this issue
Nov 15, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The above behavior made `Sizzle.contains` crash when run on certain elements within the `<template/>` element. As it turns out, we don't need to query the supposed container `documentElement` if it has the `Node.DOCUMENT_NODE` (9) `nodeType`; we can call `.contains()` directly on the `document`. That avoids the crash. However, we still need to fall back to `documentElement` if one is defined as IE <9 have a broken `.contains()` on the document. Fixes jquery/jquery#5147 Ref jquery/jquery#5158
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 15, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490. This PR pulls the new Sizzle version into jQuery's `3.x-stable` branch and backports one test from jquerygh-5158. Fixes jquerygh-5147 Ref jquery/sizzle/pull/490 Ref jquerygh-5158
3 tasks
|
Landed on The Sizzle PR: jquery/sizzle#490 |
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 16, 2022
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 16, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490. This PR pulls the new Sizzle version into jQuery's `3.x-stable` branch and backports one test from jquerygh-5158. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 16, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 16, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. A fix similar to the one from jquerygh-5158 has also been applied here to the `selector-native` version. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158
mgol
added a commit
that referenced
this issue
Nov 16, 2022
mgol
added a commit
that referenced
this issue
Nov 16, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. A fix similar to the one from gh-5158 has also been applied here to the `selector-native` version. Fixes gh-5147 Closes gh-5159 Ref jquery/sizzle#490 Ref gh-5158
|
Landed on |
mgol
added a commit
to mgol/jquery
that referenced
this issue
Nov 17, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains`. As it turns out, we don't need to query the supposed container `documentElement` if it has the `Node.DOCUMENT_NODE` (9) `nodeType`; we can call `.contains()` directly on the `document`. That avoids the crash. Fixes jquerygh-5147 Closes jquerygh-5158 (cherry picked from commit 3299236)
mgol
added a commit
to mgol/jquery
that referenced
this issue
Dec 1, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains`. As it turns out, we don't need to query the supposed container `documentElement` if it has the `Node.DOCUMENT_NODE` (9) `nodeType`; we can call `.contains()` directly on the `document`. That avoids the crash. Fixes jquerygh-5147 Closes jquerygh-5158 (cherry picked from commit 3299236)
mgol
added a commit
to mgol/jquery
that referenced
this issue
Dec 13, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains`. As it turns out, we don't need to query the supposed container `documentElement` if it has the `Node.DOCUMENT_NODE` (9) `nodeType`; we can call `.contains()` directly on the `document`. That avoids the crash. Fixes jquerygh-5147 Closes jquerygh-5158 (cherry picked from commit 3299236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
After the new IOS 16, Safari changed the behavior of
document.adoptNodewhen called on a template. It's not changing the ownerDocument any more. It leaves this on an empty document (about:blank).This causing an error at the function contains at this line, because the documentElement property is null on an empty document (about:blank).
If you change this line from
var adown = a.nodeType === 9 ? a.documentElement : a, bup = b && b.parentNode;to
var adown = a.nodeType === 9 && a.documentElement ? a.documentElement : a, bup = b && b.parentNode;it's working again.
More details can be found here and aurelia/framework#1003.
Link to test case
You can see the problem in this fiddler if you try it with Safari 16+.
If you press "add" and then "remove" you get the error.
The text was updated successfully, but these errors were encountered: