Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for ticket #9830 #567

Closed
wants to merge 1 commit into from
Closed

Patch for ticket #9830 #567

wants to merge 1 commit into from

Conversation

SaraJo
Copy link

@SaraJo SaraJo commented Oct 29, 2011

Fixed with jollysonali jyli7. We made the adjustment in line #404 of attributes.js. The attrHooks' get function sends back the getAttribute value of the element if present. If it's not present, it defaults to the current value of the element.

Let us know if you have any feedback, thank you!

@rwaldron
Copy link
Member

Awesome - can you add a test for this? Thanks!

@timmywil
Copy link
Member

There are several issues here. Most of all, the property retrieval is the only reason the value attrHook exists. The only solution is removing it.

@timmywil timmywil closed this Oct 30, 2011
@SaraJo
Copy link
Author

SaraJo commented Oct 31, 2011

I agree that it seems verbose, shall we add a conditional in the attr:
function?
Sara J Chipps
http://SaraJChipps.com
http://GirlDevelopIt.com
sarajchipps@gmail.com
862.201.3065


No trees were killed in sending this message but a large number of
electrons were terribly inconvenienced.

On Sun, Oct 30, 2011 at 2:06 PM, timmywil <
reply@reply.github.com>wrote:

There are several issues here. Most of all, the property retrieval is the
only reason the value attrHook exists. The only solution is removing it.

Reply to this email directly or view it on GitHub:
#567 (comment)

@timmywil
Copy link
Member

For now, this can be added to a project that expects to retrieve the value attribute:

delete jQuery.attrHooks.value;

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants