Accumulated, not yet pulled commits #1

Closed
wants to merge 23 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

rkatic commented Sep 3, 2010

Hope this new pull-req system will help as to merge my patches to jquery :)

Maybe I am doing something wrong (I am relatively new with git) ?

The logic doesn't seem sound here - what if you have an array followed by a plain object. In that case copyIsArray will still be true from the last iteration even though we're now working with a plain object. It seems like the copyIsArray statement would have to be before the isPlainObject one, at the very least.

I noticed that you have test cases in your ticket - why aren't there any in the patch? I'm also a bit confused as to why jQuery.extend(true, [], arr) no longer clones the array.

Owner

rkatic replied Feb 2, 2010

I noticed that you have test cases in your ticket - why aren't there any in the patch?

Well, if you wont I can add some tests related to the bug. However it is impossible to predict all future bugs anyway, and this one seams pretty illogical to me. It would make much more sense to test all types (not only arrays and plain objects) but I suppose that it would be too much.

I'm also a bit confused as to why jQuery.extend(true, [], arr) no longer clones the array.

I removed that test because it have no sense - it is same as jQuery.extend([], arr) (not deep) because all values of arr are numbers (neither arrays nor plain objects).

did you ever make a pull request for this?

Owner

rkatic replied Mar 23, 2010

I did. 9 days ago. In meantime MIX2010 takes place, so I suppose it suspended jQuery development a bit. I just made pull request again, in case the first one was "lost".

Contributor

rkatic commented Sep 10, 2010

Closed because made a new one.

@IDisposable IDisposable added a commit to IDisposable/jquery that referenced this pull request Mar 26, 2014

@IDisposable IDisposable Pass response to resolves and global events
Pass the response object (with state, data and error) to deferred.resolveWith, deferred.rejectWith and global ajaxSuccess and ajaxError events so the response body from the ajax call is available.
This is to implement option #1 of enhancement ticket 14923. http://bugs.jquery.com/ticket/14923
9eb718a

@asher00 asher00 added a commit to asher00/jquery that referenced this pull request May 29, 2014

@asher00 asher00 test2 브랜치에서 수정#1 70692cf

@fr34k8 fr34k8 referenced this pull request Jan 21, 2015

@dmethvin dmethvin Merge pull request #474 from dmethvin/fix-9521-xss-hash
Fixes #9521. Prioritize #id over <tag> to avoid XSS via location.hash.
db9e023

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment