Fix #9469. Remove semi-functional .selector property. #1006

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

dmethvin commented Oct 24, 2012

Kind of sad, removing all this saves 54 bytes and passes unit tests without any changes. I kept the selector calc in jQuery.fn.find() because $(selector, context) needs it.

Member

mikesherov commented Oct 24, 2012

Right, so this effectively says that .selector is only useful for .live which is why all tests passed.

Owner

dmethvin commented Oct 24, 2012

Although all the .live() tests are still in the event unit tests. Those won't break either, except in cases where people use .live() in a chain which was never supposed to work.

Member

mikesherov commented Oct 24, 2012

Shouldn't we be moving those to the deprecated.js?

Owner

dmethvin commented Oct 24, 2012

It could definitely go into deprecated.js, although it wasn't on the list to be removed from core in 1.9 because I suspect it is widely used.

dmethvin closed this in 69e2f06 Oct 25, 2012

@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

@dmethvin dmethvin Fix #9469. Remove semi-functional .selector property. Close gh-1006.
Saved 65 bytes.
6d284f8

dmethvin referenced this pull request in jquery/api.jquery.com Apr 6, 2015

Closed

Incorrect information for the selector property #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment