Improve replaceWith #1038
Improve replaceWith #1038
Conversation
| val = !isFunc ? value : value.call( this, i, this ); | ||
|
|
||
| if ( isDisconnected( this ) ) { | ||
| // for disconnected elements, we replace with the new content in the set. We use | ||
| // clone here to ensure that each replaced instance is unique | ||
| self[ i ] = jQuery( val ).clone()[ 0 ]; | ||
| return; | ||
| return self[ i ] = jQuery( val ).clone()[ 0 ]; |
There was a problem hiding this comment.
Why this changed behaviour? There are no tests that support a newly appointed return value...
There was a problem hiding this comment.
This behaviour isn't changed, look closely
There was a problem hiding this comment.
Ugh. Github's diff doesn't show enough lines to give context to the change. Sorry for the noise.
|
I like your implementation of |
|
Since @PaulBRamos had a patch in this area, I'm going to close this request. @Orkel can you review that code when it arrives? |
|
@PaulBRamos pull, currently, not replacing this pull, but one is affecting the other. @dmethvin, @PaulBRamos, @gibson042 I suggest to wait untill fix for #4087 will be landed (i hope it will), but remove from 1033 pull fix for @PaulBRamos who you feel about that? @dmethvin can i reopen this pull after @PaulBRamos fix will be landed? |
It's faster, smaller (-10 bytes) and simpler.