Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

No ticket: Set async to true instead of "async" in ajax/script.js (prop vs. attr) #1039

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

Krinkle commented Nov 21, 2012

follows-up ab3ba4a
@rwldrn

@Krinkle Krinkle Set async to true instead of "async" in ajax/script.js (prop vs. attr)
Someone confused properties and attributes.

This never actually caused any issues, thanks to the stable
enough internal boolean casting of all supported browsers, and
the fact that we remove it from the dom before any other script
could practically try to read this property.

Follow-up: ab3ba4a
b84a74e

@rwaldron rwaldron closed this in 4fed8eb Nov 22, 2012

Member

rwaldron commented Nov 22, 2012

LGTM 👍

Member

jaubourg commented Nov 22, 2012

FYI, this had been set to "async" back in the days because older FF had a problem with true (ie. it just didn't work with true). This has been fixed by now so \o/.

Member

Krinkle commented Nov 22, 2012

@jaubourg In that case a comment wouldn't have hurt 😉 (since it is sort of incorrect to assign a string value to a boolean property). From tracing it back with git-blame the entire script was introduced as a whole, and no mention anywhere in the commit-msg or code of why this was.

I did find an old forum thread.

Anyhow, passé now.

Member

jaubourg commented Nov 22, 2012

Was it when John commited the whole ajax rewrite? Anyway, yeah, I should have added a comment about this :/

@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

@Krinkle @rwaldron Krinkle + rwaldron Set async to true instead of async (prop vs. attr). Closes gh-1039 63fa667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment