New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13160: Propagete context of returned deferred object in Deferred.then(). #1114

Merged
merged 2 commits into from Jan 8, 2013

Conversation

Projects
None yet
3 participants
@nanto
Copy link
Contributor

nanto commented Jan 6, 2013

When returning a Deferred object resolved with a custom context in a function passed to Deferred.then(), context of the promise, which is returned from .then(), should be the custom context.

@dmethvin

This comment has been minimized.

Copy link

dmethvin commented on src/deferred.js in e7fdda9 Jan 7, 2013

This is very close to line 35 above. Could it be rewritten to eliminate the redundancy? It might be a lot smaller that way.

@dmethvin

This comment has been minimized.

Copy link

dmethvin commented on src/deferred.js in 412d910 Jan 7, 2013

Sweet!

@dmethvin

This comment has been minimized.

Copy link
Member

dmethvin commented Jan 8, 2013

This looks good to me. @jaubourg ?

@jaubourg

This comment has been minimized.

Copy link
Member

jaubourg commented Jan 8, 2013

Could use some DRYing in then but it looks good to me too.

@jaubourg jaubourg merged commit 412d910 into jquery:master Jan 8, 2013

@dmethvin

This comment has been minimized.

Copy link
Member

dmethvin commented Jan 8, 2013

@nanto can you please fill out our CLA here? http://jquery.github.com/cla.html

@jaubourg

This comment has been minimized.

Copy link
Member

jaubourg commented Jan 8, 2013

@nanto, thanks a lot for this patch btw. Awesome work you did here :)

@nanto

This comment has been minimized.

Copy link
Contributor

nanto commented Jan 9, 2013

I agreed to jQuery CLA. Thank you.

@dmethvin

This comment has been minimized.

Copy link
Member

dmethvin commented Jan 9, 2013

Thank you for your help! Your name is in the blog post today. 👏 Please contribute in the future if you find any other problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment