Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove the deprecated andSelf in favor of addBack. Fixes #13283 #1170

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

ruado1987 commented Feb 18, 2013

Remove andSelf in traversing.js and replace its usage with addBack in test files.

Owner

dmethvin commented Feb 18, 2013

We cannot remove .andSelf() yet because it hasn't been adequately deprecated. However, we could replace the uses in the unit tests as you have done here and move the line defining it to deprecated.js. Would you like to make those changes?

Can you sign our CLA at http://contribute.jquery.org/CLA/ ? I am not clear why the commit was made by a different account than yours.

Contributor

ruado1987 commented Feb 19, 2013

Yes, I am very glad to contribute those changes to the jQuery codebase.
Regarding to the difference in account names, well, it is because I use 2
different computers which are making use of different ssh keys to interact
with github. There should be no problem in this case. :).

BTW, I just completed signing the CLA.

On Tue, Feb 19, 2013 at 3:27 AM, Dave Methvin notifications@github.comwrote:

We cannot remove .andSelf() yet because it hasn't been adequately
deprecated. However, we could replace the uses in the unit tests as you
have done here and move the line defining it to deprecated.js. Would you
like to make those changes?

Can you sign our CLA at http://contribute.jquery.org/CLA/ ? I am not
clear why the commit was made by a different account tbhan yours.


Reply to this email directly or view it on GitHubhttps://github.com/jquery/jquery/pull/1170#issuecomment-13738468.

@dmethvin dmethvin closed this in 8bc7bde Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment