13471 fix off event stack overflow #1173

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@bolasblack

No description provided.

@dmethvin

This comment has been minimized.

Show comment Hide comment
@dmethvin

dmethvin Feb 18, 2013

Owner

The root problem is that an (invalid) .on(".name", fn) adds something to the event list. That causes this situation. I don't think we want to solve it this way. Would you be interested in exploring a solution from that end? The associated bug ticket is here: http://bugs.jquery.com/ticket/13471

Owner

dmethvin commented Feb 18, 2013

The root problem is that an (invalid) .on(".name", fn) adds something to the event list. That causes this situation. I don't think we want to solve it this way. Would you be interested in exploring a solution from that end? The associated bug ticket is here: http://bugs.jquery.com/ticket/13471

@bolasblack

This comment has been minimized.

Show comment Hide comment
@bolasblack

bolasblack Feb 19, 2013

maybe we need throw an error when bind this event?

i think many people (for example me) will do like this

maybe we need throw an error when bind this event?

i think many people (for example me) will do like this

@rwaldron

This comment has been minimized.

Show comment Hide comment
@rwaldron

rwaldron Feb 19, 2013

Member

I don't think many people will do this at all, the docs have never said anything about supporting the practice—not that everyone follows the docs—but it's a strange thing to do and is essentially a no-op.

The best solution is a no code solution: we simply continue forward the way we have and it's not supported and never will be

Member

rwaldron commented Feb 19, 2013

I don't think many people will do this at all, the docs have never said anything about supporting the practice—not that everyone follows the docs—but it's a strange thing to do and is essentially a no-op.

The best solution is a no code solution: we simply continue forward the way we have and it's not supported and never will be

@dmethvin

This comment has been minimized.

Show comment Hide comment
@dmethvin

dmethvin Feb 26, 2013

Owner

Landed 2bbc3d5 instead.

Owner

dmethvin commented Feb 26, 2013

Landed 2bbc3d5 instead.

@dmethvin dmethvin closed this Feb 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment