Optimisation: Use String instead of window.String. #1176

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@Krinkle
Member

Krinkle commented Feb 20, 2013

Follows-up 22e28b0.

@rwaldron

This comment has been minimized.

Show comment Hide comment
@rwaldron

rwaldron Feb 21, 2013

Member

LGTM

Member

rwaldron commented Feb 21, 2013

LGTM

@dmethvin

This comment has been minimized.

Show comment Hide comment
@dmethvin

dmethvin Feb 25, 2013

Owner

@jaubourg do you recall why it was window.String? Seems like String should always be in global scope; are there some strange environments (node?) this was trying to appease?

Owner

dmethvin commented Feb 25, 2013

@jaubourg do you recall why it was window.String? Seems like String should always be in global scope; are there some strange environments (node?) this was trying to appease?

@jaubourg

This comment has been minimized.

Show comment Hide comment
@jaubourg

jaubourg Feb 25, 2013

Member

AFAIK, it was only about getting around the linter.

Member

jaubourg commented Feb 25, 2013

AFAIK, it was only about getting around the linter.

@rwaldron

This comment has been minimized.

Show comment Hide comment
@rwaldron

rwaldron Feb 25, 2013

Member

@jaubourg I vaguely remember you and I discussing this when you were landing the Ajax re-write, which is what I'm referring to here: 22e28b0#commitcomment-2661272

Member

rwaldron commented Feb 25, 2013

@jaubourg I vaguely remember you and I discussing this when you were landing the Ajax re-write, which is what I'm referring to here: 22e28b0#commitcomment-2661272

@dmethvin dmethvin closed this in 31478b9 Feb 26, 2013

@Krinkle Krinkle deleted the Krinkle:window-prop/String branch Feb 26, 2013

gibson042 added a commit that referenced this pull request Feb 26, 2013

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment