updated Grunt to 0.4.1 (needed for node 0.10.0 compatibility) #1202

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

mgol commented Mar 13, 2013

Also, updated some other dependencies (there were some now not needed rc versions required).

Owner

dmethvin commented Mar 13, 2013

Whoa awesome! I'm falling a bit behind on the pulls but can get to this tomorrow if nobody beats me to it.

Member

mgol commented Mar 13, 2013

It might be useful to update other deps, too. I'm looking into it.

One problem with updating grunt-contrib-jshint to 0.2.0 is that it then complains about assignments where expression is expected and there are 5 such places in jQuery code (like return ( elem[ name ] = value ); etc.)

Member

rwaldron commented Mar 13, 2013

Is there an option for that?

Member

mgol commented Mar 13, 2013

The boss option should do it; at least it works with jsHint 1.1.0 but it's not used in grunt-contrib-jshint 0.2.0 yet. I'm trying to make .jshintrc forward-compatible anyway so it'll be easier to switch once grunt-contrib-jshint gets the updated jsHint.

There's one problem I can't get rid of - current .jshintrc has noempty: true but the codebase has 2 places not conforming to that; one in Sizzle, one in traversing; they're whiles with empty blocks. There are 2 options only: either to stop hacking while or to change noempty to false. It seems the option is not recognized at all by current grunt-contrib-jshint because it would throw errors otherwise.

Member

mgol commented Mar 13, 2013

One more problem: the latedef: true entry. It fails for current Sizzle since, for example, it uses the function named createCache in three places before its definition.

Member

mgol commented Mar 13, 2013

I created pull request resolving most of these problems: #1203

Member

mgol commented Mar 14, 2013

I think my current patch in pull request #1203 is ready to merge; however, this one is more important due to node breakage with current grunt.

rwaldron closed this in c5fc953 Mar 18, 2013

mgol deleted the mgol:grunt branch Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment