Update devDependencies, adjust .jshintrc to jsHint 2.x, use .jshintignore #1283

Closed
wants to merge 1 commit into from

2 participants

@mgol
jQuery Foundation member

In particular, jsHint 2.x assumes ES5 by default so the es5: true option was throwing warnings.

Related pull request for 1.x-master: #1282

@Krinkle
jQuery Foundation member

Can you update the pull message? As we've both found out now, grunt-contrib-jshint does support .jshintignore directly (by using the logic that jshint/jshint itself provides, similar to running jshint from npm from the command-line directly). It just needs to be in the root. Afaik jshint (node-jshint nor grunt-contrib-jshint) never supported it in a subdirectory.

Thanks for working on this.

Assuming tests pass, 👍

@mgol
jQuery Foundation member

@Krinkle I've updated it in the second commit already. :) Should be OK now. I'll squash it before merge as soon as it's approved. grunt executes without any warnings.

@Krinkle
jQuery Foundation member

@mzgol I'm aware :) I was referring to the pull-request summary here on GitHub.

@mgol
jQuery Foundation member

Corrected. It's all in the title now so I've just removed a non-true remark about grunt-contrib-jshint.

@mgol
jQuery Foundation member

I shortened jshint options further and corrected an incorrect pattern in .jshintignore.

Any further remark or is it ready to merge after we ship 2.0.3/1.10.2?

@mgol mgol closed this in c33108c Jul 11, 2013
@mgol mgol deleted the mgol:update_packages branch Jul 11, 2013
@mgol mgol added a commit that referenced this pull request Jul 11, 2013
@mgol mgol Update devDependencies, adjust .jshintrc to jsHint 2.x, use .jshintig…
…nore. Close gh-1283.

Conflicts:
	src/.jshintrc
	test/.jshintrc
4b7a0d4
@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@mgol mgol Update devDependencies, adjust .jshintrc to jsHint 2.x, use .jshintig…
…nore. Close gh-1283.

Conflicts:
	src/.jshintrc
	test/.jshintrc
732eb9e
@bperel bperel pushed a commit that referenced this pull request Jul 21, 2015
@mgol mgol Update devDependencies, adjust .jshintrc to jsHint 2.x, use .jshintig…
…nore. Close gh-1283.
fa5542b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment