#10568 - Animation does not work for inline elements #1318

Closed
wants to merge 0 commits into from

4 participants

@sachinjain024

Solves the animation issue mentioned in http://bugs.jquery.com/ticket/10568

Issue: We make inline elements to inline-block before animations but in this case, since display was none, inline elements were not able to get convert to inline-block and hence animation was not working as shown in the jsfiddle in above issue.

@rwaldron
jQuery Foundation member

Is it just me or are there no changes here?

@gibson042
jQuery Foundation member

Is it just me or are there no changes here?

No, I (don't) see it too. The "Commits: ∞" is a nice touch, though.

@dmethvin
jQuery Foundation member

Whoa. There was a commit here earlier. I suspect that @blunderboy force-pushed his own master back, there's a branch with the code but the PR wasn't made against it.

@blunderboy I'll close this PR, but the new one needs a test case as well. Be sure that you've signed our CLA as well, per the information at http://contribute.jquery.org . Thanks!

@dmethvin dmethvin closed this Jul 30, 2013
@sachinjain024

@dmethvin I am so sorry. I thought PR was made against the new branch I had created So forced update my master branch to remove that particular commit. I have already signed CLA on contribute.jquery.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment