Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix #14180. Allow cross-frame attachment of focusin/out. #1369

Closed
wants to merge 2 commits into from

3 participants

@dmethvin
Owner

Cross-frame stuff in general makes me queasy but this seems to work. I tried several different ways but this seemed to gzip better.

@scottgonzalez

:-)

@dmethvin
Owner

Leaking memory in my 1.x-master test so I'll wait until after this beta

@dmethvin dmethvin referenced this pull request from a commit
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit 6d5dfa0eda2c19e8838930fafff83b596654eca2)
Manually edited for conflicts.
bba8366
@dmethvin dmethvin closed this in 9b6f074
@dmethvin dmethvin referenced this pull request from a commit
@dmethvin dmethvin Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369
…."

This reverts commit bba8366.

Because cross-frame focus sucks.
469150a
@dmethvin dmethvin reopened this
@dmethvin
Owner

I think i figured out the problems here and am going to make another run at it.

@dmethvin
Owner

In my local branch this is passing all browsers but Opera 12. Swarmy is using Opera 12/15 as the versions but right now Opera is on 17 and I think we should not be running 12 at all anyway. There's perhaps a bit of controversy here because 12 is the last non-Blink version of Opera but given its low market share and the obscurity of this particular issue (cross-browser focus) I think it's fine that we dump Opera 12 Swarmy testing for now. Thoughts?

@mzgol
Collaborator

@dmethvin I disagree about Opera 12.1x, it has a pretty large market share in a number of countries; in Poland it's 5-8%, in Russia even more. I think we should keep testing on that.

I'm fine with blacklisting the nastiest test cases for this browser if that helps, though.

@mzgol
Collaborator

The important part about Opera 12.1x is that it doesn't show the user in any way that it's not the latest version. If you do an update check manually in Opera 12.16, it says it's the newest version.

Also, there is still no version of Opera Blink for Linux (they say the work is in progress).

@dmethvin dmethvin closed this in 1cecf64
@dmethvin dmethvin referenced this pull request from a commit
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit ebdb467761d756d4e52608a0df4a4d9b17da8092)
(conflicts with .data() resolved manually)
97d5383
@mescoda mescoda referenced this pull request from a commit in mescoda/jquery
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit 6d5dfa0eda2c19e8838930fafff83b596654eca2)
Manually edited for conflicts.
e5577c7
@mescoda mescoda referenced this pull request from a commit in mescoda/jquery
@dmethvin dmethvin Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369
…."

This reverts commit bba8366.

Because cross-frame focus sucks.
0f3a658
@mescoda mescoda referenced this pull request from a commit in mescoda/jquery
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit ebdb467761d756d4e52608a0df4a4d9b17da8092)
(conflicts with .data() resolved manually)
f32d1aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 23, 2013
  1. @dmethvin
Commits on Oct 26, 2013
  1. @dmethvin

    Whitespace.

    dmethvin authored
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +4 −4 src/event.js
View
8 src/event.js
@@ -735,21 +735,21 @@ if ( !support.focusinBubbles ) {
jQuery.event.special[ fix ] = {
setup: function() {
var doc = this.ownerDocument,
- attaches = data_priv.access( doc, "focusCount" );
+ attaches = data_priv.access( doc, fix );
if ( !attaches ) {
doc.addEventListener( orig, handler, true );
}
- data_priv.access( doc, "focusCount", ( attaches || 0 ) + 1 );
+ data_priv.access( doc, fix, ( attaches || 0 ) + 1 );
},
teardown: function() {
var doc = this.ownerDocument,
- attaches = data_priv.access( doc, "focusCount" ) - 1;
+ attaches = data_priv.access( doc, fix ) - 1;
if ( !attaches ) {
doc.removeEventListener( orig, handler, true );
}
- data_priv.access( doc, "focusCount", attaches );
+ data_priv.access( doc, fix, attaches );
}
};
});
Something went wrong with that request. Please try again.