Skip to content

Fix #14180. Allow cross-frame attachment of focusin/out. #1369

Closed
wants to merge 2 commits into from

3 participants

@dmethvin
jQuery Foundation member

Cross-frame stuff in general makes me queasy but this seems to work. I tried several different ways but this seemed to gzip better.

@scottgonzalez
jQuery Foundation member

:-)

@dmethvin
jQuery Foundation member

Leaking memory in my 1.x-master test so I'll wait until after this beta

@dmethvin dmethvin added a commit that referenced this pull request Oct 23, 2013
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit 6d5dfa0eda2c19e8838930fafff83b596654eca2)
Manually edited for conflicts.
bba8366
@dmethvin dmethvin closed this in 9b6f074 Oct 23, 2013
@dmethvin dmethvin added a commit that referenced this pull request Oct 23, 2013
@dmethvin dmethvin Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369
…."

This reverts commit bba8366.

Because cross-frame focus sucks.
469150a
@dmethvin dmethvin added a commit that referenced this pull request Oct 23, 2013
@dmethvin dmethvin Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369
…."

This reverts commit 9b6f074.
eca79fb
@dmethvin dmethvin reopened this Oct 23, 2013
@dmethvin
jQuery Foundation member

I think i figured out the problems here and am going to make another run at it.

@dmethvin
jQuery Foundation member

In my local branch this is passing all browsers but Opera 12. Swarmy is using Opera 12/15 as the versions but right now Opera is on 17 and I think we should not be running 12 at all anyway. There's perhaps a bit of controversy here because 12 is the last non-Blink version of Opera but given its low market share and the obscurity of this particular issue (cross-browser focus) I think it's fine that we dump Opera 12 Swarmy testing for now. Thoughts?

@mgol
jQuery Foundation member
mgol commented Oct 26, 2013

@dmethvin I disagree about Opera 12.1x, it has a pretty large market share in a number of countries; in Poland it's 5-8%, in Russia even more. I think we should keep testing on that.

I'm fine with blacklisting the nastiest test cases for this browser if that helps, though.

@mgol
jQuery Foundation member
mgol commented Oct 26, 2013

The important part about Opera 12.1x is that it doesn't show the user in any way that it's not the latest version. If you do an update check manually in Opera 12.16, it says it's the newest version.

Also, there is still no version of Opera Blink for Linux (they say the work is in progress).

@dmethvin dmethvin closed this in 1cecf64 Nov 13, 2013
@dmethvin dmethvin added a commit that referenced this pull request Nov 13, 2013
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit ebdb467761d756d4e52608a0df4a4d9b17da8092)
(conflicts with .data() resolved manually)
97d5383
@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit 6d5dfa0eda2c19e8838930fafff83b596654eca2)
Manually edited for conflicts.
e5577c7
@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@dmethvin dmethvin Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369
…."

This reverts commit bba8366.

Because cross-frame focus sucks.
0f3a658
@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@dmethvin dmethvin Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369.
(cherry picked from commit ebdb467761d756d4e52608a0df4a4d9b17da8092)
(conflicts with .data() resolved manually)
f32d1aa
@bperel bperel pushed a commit that referenced this pull request Jul 21, 2015
@dmethvin dmethvin Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369
…."

This reverts commit 9b6f074.
4f7d10e
@dmethvin dmethvin deleted the dmethvin:14180 branch Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.