Use grunt and bower packages as local dependencies #1433

Closed
wants to merge 1 commit into
from

3 participants

@markelog
jQuery Foundation member

What this PR proposes:

  • Use grunt-bower-task package to get control of bower modules
  • Remove grunt-cli and bower global dependencies (bower as local package corresponds with previous item). Wait, global packages as local ones? It's not supported! It's confusing! It's not recommended! It's madness! Turn's out, it's perfectly fine.
  • Add build command to package.json, so jQuery could be builded with one command, but don't forget to emphasizes about grunt commands as a preferable way to work with jQuery
  • Update readme to reflect these changes

/cc @timmywil

@mgol mgol commented on the diff Nov 13, 2013
.gitignore
node_modules
-bower_components
@mgol
jQuery Foundation member
mgol added a line comment Nov 13, 2013

Why the rename?

@markelog
jQuery Foundation member
markelog added a line comment Nov 13, 2013

It's not a rename, if it was, i would edit the .bowerrc file. bower_components contains all modules files, this folder will be cleaned up after bower install, bower_modules on the other hand, contains only essentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@timmywil
jQuery Foundation member

Turn's out, it's perfectly fine.

I don't think npm saying that it works is the same thing as saying that it's perfectly fine, but I've succumbed at this point.

@timmywil
jQuery Foundation member

I don't see anything I would change off hand.

@dmethvin
jQuery Foundation member

Okay okay, you made your point! 😄 Land this sucker.

@timmywil timmywil closed this in ac7ff97 Nov 14, 2013
@markelog
jQuery Foundation member

Hm, looks like my name was thrown out from the landing commit, oh well.

@timmywil
jQuery Foundation member

@markelog woops! Sorry Oleg! Forgot to set --author. I'm usually more careful. :(

@timmywil
jQuery Foundation member

@markelog next time I write something, I'll make you the author ;)

@ghost

Nem látok semmit, azt megváltoztatni ki kezét.ˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇˇ^^^^^^^^^^^^^^^^^^^,,,,,,,,,,,,__________________??????????..............,

@mescoda mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@timmywil timmywil Use grunt and bower packages as local dependencies. Close gh-1433. ee295ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment